From 368ee26b08a8a8e90e0a551994230c813f43a13a Mon Sep 17 00:00:00 2001 From: Riya Saxena Date: Mon, 5 Aug 2024 09:58:58 -0700 Subject: [PATCH 1/3] add ; to tests Signed-off-by: Riya Saxena --- .../1_email_senders_and_groups.spec.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cypress/integration/plugins/notifications-dashboards/1_email_senders_and_groups.spec.js b/cypress/integration/plugins/notifications-dashboards/1_email_senders_and_groups.spec.js index 92d276176..530a3c0c4 100644 --- a/cypress/integration/plugins/notifications-dashboards/1_email_senders_and_groups.spec.js +++ b/cypress/integration/plugins/notifications-dashboards/1_email_senders_and_groups.spec.js @@ -164,7 +164,7 @@ describe('Test delete senders', () => { force: true, }); cy.wait(NOTIFICATIONS_DELAY); - cy.get('input[placeholder="delete"]').should('be.visible').type('delete') + cy.get('input[placeholder="delete"]').should('be.visible').type('delete'); cy.wait(NOTIFICATIONS_DELAY); cy.get('[data-test-subj="delete-sender-modal-delete-button"]').click(); cy.contains('successfully deleted.').should('exist'); @@ -178,7 +178,7 @@ describe('Test delete senders', () => { force: true, }); cy.wait(NOTIFICATIONS_DELAY); - cy.get('input[placeholder="delete"]').should('be.visible').type('delete') + cy.get('input[placeholder="delete"]').should('be.visible').type('delete'); cy.wait(NOTIFICATIONS_DELAY); cy.get('[data-test-subj="delete-sender-modal-delete-button"]').click(); cy.contains('successfully deleted.').should('exist'); From 8ebc163766168f3c9465790d5f3b54916c3c5d09 Mon Sep 17 00:00:00 2001 From: Riya Saxena Date: Mon, 5 Aug 2024 10:55:56 -0700 Subject: [PATCH 2/3] fix channel tests in notifications Signed-off-by: Riya Saxena --- .../plugins/notifications-dashboards/2_channels.spec.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/cypress/integration/plugins/notifications-dashboards/2_channels.spec.js b/cypress/integration/plugins/notifications-dashboards/2_channels.spec.js index bd5766e86..be783bec4 100644 --- a/cypress/integration/plugins/notifications-dashboards/2_channels.spec.js +++ b/cypress/integration/plugins/notifications-dashboards/2_channels.spec.js @@ -35,7 +35,7 @@ describe('Test create channels', () => { cy.get('[placeholder="Enter channel name"]').type('Test slack channel'); cy.get('[data-test-subj="create-channel-slack-webhook-input"]').type( - 'https://sample-slack-webhook' + 'https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2' ); cy.wait(NOTIFICATIONS_DELAY); cy.get('[data-test-subj="create-channel-send-test-message-button"]').click({ @@ -44,10 +44,12 @@ describe('Test create channels', () => { cy.wait(NOTIFICATIONS_DELAY); // This needs some time to appear as it will wait for backend call to timeout cy.contains('test message.').should('exist'); + cy.wait(NOTIFICATIONS_DELAY); cy.get('[data-test-subj="create-channel-create-button"]').click({ force: true, }); + cy.wait(NOTIFICATIONS_DELAY); cy.contains('successfully created.').should('exist'); }); @@ -62,11 +64,12 @@ describe('Test create channels', () => { cy.wait(NOTIFICATIONS_DELAY); cy.get('[data-test-subj="create-channel-chime-webhook-input"]').type( - 'https://sample-chime-webhook' + 'https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456' ); cy.wait(NOTIFICATIONS_DELAY); cy.get('[data-test-subj="create-channel-create-button"]').click(); + cy.wait(NOTIFICATIONS_DELAY); cy.contains('successfully created.').should('exist'); }); From 47d9dfc9bfcead0815d17f1f61e5c66d088c54ee Mon Sep 17 00:00:00 2001 From: Riya Saxena Date: Mon, 5 Aug 2024 11:16:41 -0700 Subject: [PATCH 3/3] fix channel tests in notifications Signed-off-by: Riya Saxena --- .../plugins/notifications-dashboards/test_chime_channel.json | 2 +- .../plugins/notifications-dashboards/test_slack_channel.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cypress/fixtures/plugins/notifications-dashboards/test_chime_channel.json b/cypress/fixtures/plugins/notifications-dashboards/test_chime_channel.json index feb56cc1f..e3e4b214a 100644 --- a/cypress/fixtures/plugins/notifications-dashboards/test_chime_channel.json +++ b/cypress/fixtures/plugins/notifications-dashboards/test_chime_channel.json @@ -5,7 +5,7 @@ "config_type": "chime", "is_enabled": true, "chime": { - "url": "https://sample-chime-webhook" + "url": "https://hooks.chime.aws/incomingwebhooks/sample_chime_url?token=123456" } } } \ No newline at end of file diff --git a/cypress/fixtures/plugins/notifications-dashboards/test_slack_channel.json b/cypress/fixtures/plugins/notifications-dashboards/test_slack_channel.json index 7643b2b0d..e24a94462 100644 --- a/cypress/fixtures/plugins/notifications-dashboards/test_slack_channel.json +++ b/cypress/fixtures/plugins/notifications-dashboards/test_slack_channel.json @@ -5,7 +5,7 @@ "config_type": "slack", "is_enabled": true, "slack": { - "url": "https://sample-slack-webhook" + "url": "https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2" } } } \ No newline at end of file