Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support data_type property for KnnVectorProperty #1254

Closed
andrewrchen05 opened this issue Oct 28, 2024 · 1 comment · Fixed by #1255
Closed

[FEATURE] Support data_type property for KnnVectorProperty #1254

andrewrchen05 opened this issue Oct 28, 2024 · 1 comment · Fixed by #1255
Labels
enhancement New feature or request

Comments

@andrewrchen05
Copy link

Is your feature request related to a problem?

Binary vectors are supported but data_type is not a property for KnnVector

What solution would you like?

I want data_type to be supported in the KnnVectorProperty in the Java Client so I can call GetIndex to verify the data_type of an index https://javadoc.io/doc/org.opensearch.client/opensearch-java/latest/org/opensearch/client/opensearch/_types/mapping/KnnVectorProperty.html

                "vector": {
                    "type": "knn_vector",
                    "dimension": 1024,
                    "data_type": "binary",
                    "method": {
                        "engine": "faiss",
                        "space_type": "hamming",
                        "name": "hnsw",
                        "parameters": {}
                    }
                }

What alternatives have you considered?

Using generic client

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@andrewrchen05 andrewrchen05 added enhancement New feature or request untriaged labels Oct 28, 2024
@Xtansia Xtansia removed the untriaged label Oct 28, 2024
@dblock
Copy link
Member

dblock commented Oct 28, 2024

I see it here in the API spec so codegen will pick it up with some more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants