Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing support for "cjk" analyzer #592

Closed
MikePieperSer opened this issue Aug 2, 2023 · 4 comments · Fixed by #604
Closed

[BUG] Missing support for "cjk" analyzer #592

MikePieperSer opened this issue Aug 2, 2023 · 4 comments · Fixed by #604
Labels
bug Something isn't working untriaged

Comments

@MikePieperSer
Copy link
Contributor

What is the bug?

For analyzer "cjk" exists no method.

Via REST/JSON I can use the analyzer.

How can one reproduce the bug?

            // create an index
            CreateIndexRequest createIndexRequest = new CreateIndexRequest.Builder().index(index)
                                                                                    .settings(b -> b
                                                                                        .analysis(ab -> ab
                                                                                            .analyzer("ko_analyzer", aab->aab
                                                                                       >>>>     .cjk()  <<<<
                                                                                            )
                                                                                        )
                                                                                    ).build();
            CreateIndexResponse createIndexResponse = client.indices().create(createIndexRequest);

What is the expected behavior?

That "cjk" analyzer is supported like all the other analyzers.

What is your host/environment?

AWS Opensearch Serverless / java-client 2.6.0

Do you have any screenshots?

No.

Do you have any additional context?

No.

@MikePieperSer MikePieperSer added bug Something isn't working untriaged labels Aug 2, 2023
@dblock
Copy link
Member

dblock commented Aug 2, 2023

Looks like it's not implemented ;(

Want to try to add it?

@MikePieperSer
Copy link
Contributor Author

Yeah, for sure. I've already looked at it, but the sources seem to be generated. I didn't found the generator. Can you point me into the rigtht direction?

@dblock
Copy link
Member

dblock commented Aug 3, 2023

@MikePieperSer @Xtansia will know how this stuff works now

@Xtansia
Copy link
Collaborator

Xtansia commented Aug 7, 2023

Yeah, for sure. I've already looked at it, but the sources seem to be generated. I didn't found the generator. Can you point me into the rigtht direction?

The sources were generated in the past, however currently they are not (there's some initiatives in progress to eventually remediate this). So for the time being any bindings will need to be hand written, it'd be awesome if you're willing to take a go at it. I'm not personally super familiar with the analyzers specifically, but happy to try to answer any questions you might have!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants