Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] BulkRequest estimated size #638

Open
andrewparmet opened this issue Sep 26, 2023 · 3 comments
Open

[FEATURE] BulkRequest estimated size #638

andrewparmet opened this issue Sep 26, 2023 · 3 comments
Labels
enhancement New feature or request performance Make it fast!

Comments

@andrewparmet
Copy link
Contributor

Is your feature request related to a problem?

The RestHighLevelClient had a convenience method on BulkRequest that allowed us to dynamically batch bulk operations without exceeding OpenSearch's max request size.

What solution would you like?

Is this available in the current client? If not, can it be added? I don't mind porting the old implementation if needed.

What alternatives have you considered?

I'm implementing it myself but I have to use reflection to access private fields on UpdateOperationData such as the script to get its length if I don't want to serialize it just to get its size and then have the library reserialize it again when it sends it as part of the request.

Do you have any additional context?

Nope!

@andrewparmet andrewparmet added enhancement New feature or request untriaged labels Sep 26, 2023
@andrewparmet
Copy link
Contributor Author

I'm also curious about the implementation itself... why is script length doubled and update operations added without the request overhead?

@dblock dblock added performance Make it fast! and removed untriaged labels Dec 4, 2023
@peter-ponzel
Copy link

are there any news on that topic ?

@dblock
Copy link
Member

dblock commented Oct 10, 2024

This needs to be investigated and implemented, we welcome your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Make it fast!
Projects
None yet
Development

No branches or pull requests

3 participants