Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The docs refer to the demo directory, however it isn't in our code base. #43

Open
epugh opened this issue Sep 18, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@epugh
Copy link

epugh commented Sep 18, 2024

What is the bug?

In the docs, that we are coping over, we have http://localhost:4000/docs/latest/search-plugins/ltr/logging-features/ page that says:

image

However, that link, which should be https://github.com/o19s/OpenSearch-learning-to-rank/tree/master/demo doesn't work because that directory was never ported over.

How can one reproduce the bug?

Use this PR for the documentation and stand it up: opensearch-project/documentation-website#8336

What is the expected behavior?

Either the link works, or we rework it to not have a link

@epugh
Copy link
Author

epugh commented Oct 2, 2024

Good candidate for @JohannesDaniel to pick up...

@dblock
Copy link
Member

dblock commented Oct 7, 2024

[Catch All Triage - 1, 2, 3, 4]

@sstults
Copy link
Collaborator

sstults commented Nov 12, 2024

@epugh it looks like this was edited out of the docs. Okay to close?

@epugh
Copy link
Author

epugh commented Nov 12, 2024

I suppose so... Did we add back the docs though? I see https://github.com/opensearch-project/opensearch-learning-to-rank-base/tree/main/demo, is that the missing dir? Looking back at the original docs, they pointed to https://github.com/o19s/elasticsearch-learning-to-rank/tree/main/demo.

So I think the right fix is to add a PR to the docs website restoring the link to our demo dir...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants