Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Instructions to ./gradlew run -Dopensearch.experimental.feature.extensions.enabled=true don't enable extensions #916

Closed
dblock opened this issue Jul 31, 2023 · 1 comment · Fixed by #918
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@dblock
Copy link
Member

dblock commented Jul 31, 2023

What is the bug?

Running ./gradlew run -Dopensearch.experimental.feature.extensions.enabled=true does not pass through opensearch.experimental.feature.extensions.enabled=true and therefore doesn't enable extensions feature flag.

How can one reproduce the bug?

Read https://github.com/opensearch-project/opensearch-sdk-java/blob/5f9b9b372d6fb5d6562c0dbce4cabf249436ca63/DEVELOPER_GUIDE.md#option-2 that says to run the following.

./gradlew run -Dopensearch.experimental.feature.extensions.enabled=true

Doesn't pickup opensearch.experimental.feature.extensions.enabled.

$ 
osx ~/source/opensearch-project/openseach-sdk-py/dblock (main)$ curl -X POST localhost:9200/_extensions/initialize -H "Content-Type:application/json" -d'{}'
{"error":"no handler found for uri [/_extensions/initialize] and method [POST]"}

What is the expected behavior?

Extensions feature flag to be enabled.

What is your host/environment?

Mac OS

@dblock dblock added bug Something isn't working untriaged labels Jul 31, 2023
@dbwiddis
Copy link
Member

dbwiddis commented Aug 2, 2023

Seems the ability to pass feature flags on the command line is intended to be removed and only supported in opensearch.yml, reading comments on opensearch-project/OpenSearch#4959 (which implies the capability is only provided for backwards compatibility).

It does seem possible that --args="-Dopensearch.experimental.feature.extensions.enabled=true" could work but I think that may require the application plugin and I don't see that used.

@dbwiddis dbwiddis added documentation Improvements or additions to documentation and removed untriaged labels Aug 2, 2023
@dbwiddis dbwiddis self-assigned this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants