-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OuiCallOut - Add props to enable dismissible behavior #880
Comments
For the I see |
So the showing and hiding of a modal is controlled by the user, so the onClose is important in that flow. For the call out, I think a more opinionated flow where the user can only specify if the model is dismissible, but does not have a say in how to do it. We can always expand this in future by allowing an onClose function to override the default. But I don't think we need to complicate that for now. @KrooshalUX what do you think? |
Closed with #985 |
Currently OuiCallOut provides builders a way to communicate relevant information to a users experience in relationship to a page or flow, however, in some cases the information does not always need to persist, but utilizing OuiToast is not appropriate (feature announcements, for example).
In order to give vital real-estate back to the end user, it is appropriate to allow builders to configure if a call-out should be static or dismissible by the end user.
dismissible
can be set toTRUE
orFALSE
except in the case wherecolor
is set todanger
orwarning
(danger
is used in Form validation and is required by the design system to appear staticallydismissilbe
isFALSE
, as dismissible is a sub-variant of the base componentdismissible
is set toTRUE
,OuiIcon type=cross
should appear in upper right hand corner of OuiCallOutOnClick
ofOuiIcon type=cross
- OuiCallOut should disappear from the page without causing page refresh- Is this a property of the component or a property of the implementation by builders (and therefore this requirement would be associated with a dashboards issue to implement OuiCallOut ex: Notifying users of how to override Dark Mode by Default)?
- Since there is no User object, this may be limited to session or device
Designs (primary, hover)
Notes: This dismissible variation of
OuiCallOut
(or anyOuiCallOut
) is not intended to display confirmations of user CRUD actions - for that, builders should continue to useOuiToast
. This and other guidance will be explicitly updated on within #883.The text was updated successfully, but these errors were encountered: