Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]SAML Authentication can not be enabled with Anonymous #1173

Closed
aoguan1990 opened this issue Oct 27, 2022 · 14 comments
Closed

[Enhancement]SAML Authentication can not be enabled with Anonymous #1173

aoguan1990 opened this issue Oct 27, 2022 · 14 comments
Labels
bug Something isn't working triaged

Comments

@aoguan1990
Copy link
Contributor

What is the bug?
A clear and concise description of the bug.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Enable the following feature flag in opensearch_dashboards.yml
    opensearch_security.auth.type: 'saml'
    opensearch_security.auth.anonymous_auth_enabled: true
  2. Go to OpenSearch Dashboards: http://localhost:5601/
  3. Got Internal Exception:
    image

What is the expected behavior?
User is able to login as Anonymous and by SAML based external IDP.

@aoguan1990 aoguan1990 added bug Something isn't working untriaged labels Oct 27, 2022
@devardee
Copy link
Contributor

I guess that happens because in OSD security plugin, when SAML authentication beings it will get the SAML request (challenge) by hitting the authinfo api which will return anonymous user when anonymous auth is enabled. One way to force SAML challenge on unauthenticated requests is to introduce a header (ex : FORCE-AUTH:true), which will ensure anonymous user is not injected for unauthenticated requests, thoughts ?

@cwperks
Copy link
Member

cwperks commented Oct 31, 2022

@opensearch-project/transfer-request Please move this to security-dashboards-plugin

@cwperks
Copy link
Member

cwperks commented Oct 31, 2022

[Triage] @cliu123 Please follow-up on this issue.

@cliu123
Copy link
Member

cliu123 commented Oct 31, 2022

@aoguan1990 Is this a regression caused by multi-auth? If not, we can fix it separately.

@aoguan1990
Copy link
Contributor Author

@cliu123 This is an existing issue with SAML. Multi-auth did not change any implementation for SAML authentication. Multi-auth also does not support SAML and Anonymous to be enabled at the same time, which is signed off by PM. As per discussion with developer from Search Guard during the training, Anonymous with SAML is not implemented. Use this issue to keep track of the enhancement.

@aoguan1990 aoguan1990 changed the title [BUG]SAML Authentication can not be enabled with Anonymous [Enhancement]SAML Authentication can not be enabled with Anonymous Oct 31, 2022
@aoguan1990
Copy link
Contributor Author

aoguan1990 commented Oct 31, 2022

@opensearch-project/transfer-request Please move this to security-dashboards-plugin
@cwperks SAML authentication logic is implemented by backend security plugin. So this issue should be tracked under /security repo.

@peternied
Copy link
Member

Multi-auth also does not support SAML and Anonymous to be enabled at the same time, which is signed off by PM

@aoguan1990 OpenSearch Project's own https://build.ci.opensearch.org/ uses Anonymous + SAML authentication for its Jenkins instance. Do you have a link to where decision was documented or @mention the person behind the decision?

Even if we don't support the scenario we, we should make sure its documented and include appropriate in-product blocks to prevent the configuration from being set.

@peternied peternied transferred this issue from opensearch-project/security Oct 31, 2022
@DarshitChanpura
Copy link
Member

@aoguan1990 Would you need any help answering the question above?

@aoguan1990
Copy link
Contributor Author

@peternied @DarshitChanpura Thank you so much for following up on this issue. Do you by any chance can reproduce this issue?

@peternied
Copy link
Member

@aoguan1990 this issue has not been worked on AFAIK so we haven't attempted to reproduce - is there a pull request that allows SAML + anonymous auth over the break?

@stephen-crawford
Copy link
Contributor

[Triage] @davidlago could you follow up with @aoguan1990. Thank you!

@stephen-crawford
Copy link
Contributor

[Triage 2/6] Moving from "sprint backlog" to backlog.

@davidlago
Copy link

Closed by mistake, reopening.

@davidlago
Copy link

Closing in favor of #1236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

8 participants