Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] OpenSearch logo should inherit from OpenSearch Dashboards branding configuration (and be theme-aware) #1524

Closed
Tracked by #1471 ...
joshuarrrr opened this issue Jul 21, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers triaged v2.10.0

Comments

@joshuarrrr
Copy link
Member

Is your feature request related to a problem?
OpenSearch Dashboards provides users with the ability to customize branding (including logos) via the yaml config file: https://opensearch.org/docs/latest/dashboards/branding/

Logos and marks in this system are "theme-aware" because they use dark/light mode variants appropriately. In contrast, the
security-dashboards plugin provides it's own default OpenSearch logo, as the default, with no light/dark variants or logic:

import defaultBrandImage from '../../assets/opensearch_logo_h.svg';

What solution would you like?

Rather than providing separate default assets, the login page should be refactored to pull the correct default logo assets from the branding service of OpenSearch Dashboards. We should also consider merging and consolidating branding configuration options.

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
Add any other context or screenshots about the feature request here.

@stephen-crawford
Copy link
Contributor

[Triage] Thank you for filing this issue @joshuarrrr. This change is part of broader OUI implementation. Labeling good first issue.

@stephen-crawford
Copy link
Contributor

Closing this as it is part of #1529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triaged v2.10.0
Projects
None yet
Development

No branches or pull requests

2 participants