Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Is es-lint-plugin-cypress dependency used? #1745

Closed
derek-ho opened this issue Jan 22, 2024 · 2 comments
Closed

[FEATURE] Is es-lint-plugin-cypress dependency used? #1745

derek-ho opened this issue Jan 22, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed, need help from community triaged

Comments

@derek-ho
Copy link
Collaborator

Is your feature request related to a problem?
I noticed that there is this dependency: https://github.com/opensearch-project/security-dashboards-plugin/blob/main/package.json#L41 that seems not to be used.
https://github.com/search?q=repo%3Aopensearch-project%2Fsecurity-dashboards-plugin+eslint-plugin-cypress&type=code

Can it be removed? Or at least moved to a dev dependency? By name it seems to only be used by cypress.

@derek-ho derek-ho added enhancement New feature or request untriaged labels Jan 22, 2024
@stephen-crawford
Copy link
Contributor

[Triage] Hi @derek-ho, nice catch. Seems like someone should go ahead and make sure that this is not needed and remove it if so.

@stephen-crawford stephen-crawford added help wanted Extra attention is needed, need help from community good first issue Good for newcomers triaged and removed untriaged labels Jan 22, 2024
@derek-ho
Copy link
Collaborator Author

Closing with the merge of: #1746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed, need help from community triaged
Projects
None yet
Development

No branches or pull requests

2 participants