Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Investigate and clean up tenancy logic #1761

Open
derek-ho opened this issue Jan 29, 2024 · 1 comment
Open

[BUG] Investigate and clean up tenancy logic #1761

derek-ho opened this issue Jan 29, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers triaged

Comments

@derek-ho
Copy link
Collaborator

What is the bug?
Currently, there are a few problems with the tenancy logic that lead to confusing behavior:

  • Tenany popup related settings are stored in session/local storage. This may lead to unexpected and inconsistent behavior. Instead, this setting should just be computed on login, if it is not too heavy of an operation.
  • The tenany popup is selected as global, even if you don't have access to that tenant, with the circle grayed out, and if you have unselected it you cannot reselect it
  • The tenany icon is showing as "global" even if tenany is disabled.

All of these are side effects of complicated logic, so this issue is to clean up everything and make it easier to read and develop on.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

What is the expected behavior?
A clear and concise description of what you expected to happen.

What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.

@stephen-crawford
Copy link
Contributor

[Triage] Hi @derek-ho, thanks for filing this issue. It sounds like you are mostly interested in refactoring the tenancy logic. Given the description, that seems like a good idea and we can go ahead and mark this issue as complete when the code has been refactored to a more concise state.

@stephen-crawford stephen-crawford added triaged enhancement New feature or request good first issue Good for newcomers and removed untriaged bug Something isn't working labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triaged
Projects
None yet
Development

No branches or pull requests

2 participants