Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Refactor Request Type interface to be more clear #1904

Closed
derek-ho opened this issue Apr 25, 2024 · 2 comments
Closed

[FEATURE] Refactor Request Type interface to be more clear #1904

derek-ho opened this issue Apr 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@derek-ho
Copy link
Collaborator

Is your feature request related to a problem?
With the introduction of multiple datasources feature, two new interfaces were introduced: RequestParams and RequestTypeParams. During PR review there was confusion about these two types: #1888 (comment). This issue is as a placeholder to fast follow up around the naming and see if there is a way to consolidate these two to avoid confusion

What solution would you like?
Consolidation of the two interfaces and/or removal of the general method

What alternatives have you considered?
None
Do you have any additional context?
None

@stephen-crawford
Copy link
Contributor

[Triage] Hi @derek-ho thank you for filing this issue. This looks like a follow-up issue. I will leave without the label until you add your follow-up.

@derek-ho
Copy link
Collaborator Author

derek-ho commented May 6, 2024

This is no longer applicable as part of the PR merged we refactored it to go through another class

@derek-ho derek-ho closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants