Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Re-enter password text-box should highlight whether passwords match. #1939

Open
DarshitChanpura opened this issue May 6, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers triaged

Comments

@DarshitChanpura
Copy link
Member

DarshitChanpura commented May 6, 2024

Is your feature request related to a problem?
When creating a user in OpenSearch Security, a password needs to be supplied. This password is entered twice for confirmation purposes.

Currently, there is no preemptive verification of value entered in Re-enter password field with the password entered above. Only way to know if your passwords don't match is when you click on Create, a toast pops stating that Passwords do not match. This, IMO, is slightly bad user experience requiring an extra click for confirmation.

What solution would you like?
Re-enter password should be matched and high-lighted in red if passwords do not match (green otherwise ?). Additionally, Create button can be disabled if passwords do not match.

Screenshots for additional context:
Screenshot 2024-05-06 at 2 59 18 PM

Screenshot 2024-05-06 at 3 02 35 PM

@DarshitChanpura DarshitChanpura added enhancement New feature or request untriaged good first issue Good for newcomers labels May 6, 2024
@derek-ho
Copy link
Collaborator

derek-ho commented May 9, 2024

Looks like this can help: https://oui.opensearch.org/1.0/#/forms/form-validation

@cwperks
Copy link
Member

cwperks commented May 13, 2024

[Triage] Thanks for filing this issue. Can this also be extended to reset password UX?

Should the create button be disabled entirely if the form is invalid and only enabled if the input is valid?

@cwperks cwperks added triaged and removed untriaged labels May 13, 2024
@DarshitChanpura
Copy link
Member Author

Can this also be extended to reset password UX?

Yes.

Should the create button be disabled entirely if the form is invalid and only enabled if the input is valid?

This is a good approach IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triaged
Projects
None yet
Development

No branches or pull requests

3 participants