Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add a view button for password input text-box #1940

Closed
DarshitChanpura opened this issue May 8, 2024 · 3 comments · Fixed by #1980
Closed

[FEATURE] Add a view button for password input text-box #1940

DarshitChanpura opened this issue May 8, 2024 · 3 comments · Fixed by #1980
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers triaged

Comments

@DarshitChanpura
Copy link
Member

We should add a View button to password input field. This would allow users to peek at their typed password.
Something like:
Screenshot 2024-05-08 at 12 11 17 PM

The view button can be implemented as 1 of the 2 following behaviors:

  1. Password is only visible when holding the view button down.
  2. View button acts as a toggle between displaying password in plain-text and masking it.
@DarshitChanpura DarshitChanpura added enhancement New feature or request untriaged good first issue Good for newcomers labels May 8, 2024
@derek-ho
Copy link
Collaborator

derek-ho commented May 9, 2024

@cwperks cwperks added triaged and removed untriaged labels May 13, 2024
@cwperks
Copy link
Member

cwperks commented May 13, 2024

[Triage] Thank you for the feature request @DarshitChanpura. Does OUI currently support a reveal button?

@DarshitChanpura
Copy link
Member Author

Yes, however OUI comes with its own set of web-pack compilation failures. We'll probly have to address those along-with this fix, if we plan to use the OUI component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants