From deeb44931721e4628c6b25c804b2c5994daf8035 Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Wed, 20 Sep 2023 08:36:58 +0100 Subject: [PATCH 01/15] changing return to dashboards with functioning logout button on error page Signed-off-by: leanne.laceybyrne@eliatra.com --- public/apps/customerror/custom-error.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/public/apps/customerror/custom-error.tsx b/public/apps/customerror/custom-error.tsx index eb4dd9f2e..fab81c218 100644 --- a/public/apps/customerror/custom-error.tsx +++ b/public/apps/customerror/custom-error.tsx @@ -21,6 +21,7 @@ import { Router, Route } from 'react-router-dom'; import { ERROR_MISSING_ROLE_PATH } from '../../../common'; import { ClientConfigType } from '../../types'; import './_index.scss'; +import { logout } from '../account/utils'; interface CustomErrorDeps { title: string; @@ -45,8 +46,8 @@ export function CustomErrorPage(props: CustomErrorDeps) { {props.subtitle} - - Back to OpenSearch Dashboards Home + logout(props.http, '')} fullWidth> + Logout ); From de7215a1a800a70ff874dfe605cf2ec0dce79272 Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Wed, 20 Sep 2023 10:00:59 +0100 Subject: [PATCH 02/15] unit tests in progress for logout button on custom error page Signed-off-by: leanne.laceybyrne@eliatra.com --- .../customerror/test/custom-error.test.tsx | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 public/apps/customerror/test/custom-error.test.tsx diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx new file mode 100644 index 000000000..3af5171aa --- /dev/null +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -0,0 +1,44 @@ +/* + * Copyright OpenSearch Contributors + * + * Licensed under the Apache License, Version 2.0 (the "License"). + * You may not use this file except in compliance with the License. + * A copy of the License is located at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * or in the "license" file accompanying this file. This file is distributed + * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either + * express or implied. See the License for the specific language governing + * permissions and limitations under the License. + */ + +import { shallow } from 'enzyme'; +import React from 'react'; +import { CustomErrorPage } from '../custom-error'; +import { logout } from '../utils'; + +jest.mock('../utils', () => ({ + logout: jest.fn(), +})); + +describe('Custom error test', () => { + it('renders', () => { + const component = shallow( + + ); + expect(component).toMatchSnapshot(); + + // component.find('[data-test-subj="log-out-3"]').simulate('click'); + + // expect(logout).toBeCalled(); + }); +}) \ No newline at end of file From f83047f51a394c2c7d2fb2b16fef7eefbc8bcba9 Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Wed, 20 Sep 2023 16:16:16 +0100 Subject: [PATCH 03/15] unit tests in progress for logout button on custom error page Signed-off-by: leanne.laceybyrne@eliatra.com --- .../customerror/test/custom-error.test.tsx | 31 ++++++++----------- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index 3af5171aa..742dee8c6 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -16,7 +16,6 @@ import { shallow } from 'enzyme'; import React from 'react'; import { CustomErrorPage } from '../custom-error'; -import { logout } from '../utils'; jest.mock('../utils', () => ({ logout: jest.fn(), @@ -24,21 +23,17 @@ jest.mock('../utils', () => ({ describe('Custom error test', () => { it('renders', () => { - const component = shallow( - - ); - expect(component).toMatchSnapshot(); - - // component.find('[data-test-subj="log-out-3"]').simulate('click'); - - // expect(logout).toBeCalled(); - }); + const component = shallow( + + ); + expect(component).toMatchSnapshot(); + }); }) \ No newline at end of file From 5cc418e742c9f991c7c59b2b857febf21d333f9f Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Wed, 20 Sep 2023 16:52:49 +0100 Subject: [PATCH 04/15] unit tests in progress Signed-off-by: leanne.laceybyrne@eliatra.com --- .../customerror/test/custom-error.test.tsx | 27 +++++++++---------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index 742dee8c6..766232df2 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -12,7 +12,6 @@ * express or implied. See the License for the specific language governing * permissions and limitations under the License. */ - import { shallow } from 'enzyme'; import React from 'react'; import { CustomErrorPage } from '../custom-error'; @@ -22,18 +21,18 @@ jest.mock('../utils', () => ({ })); describe('Custom error test', () => { - it('renders', () => { - const component = shallow( - - ); - expect(component).toMatchSnapshot(); + it('renders', () => { + const component = shallow( + + ); + expect(component).toMatchSnapshot(); }); }) \ No newline at end of file From 19515f02d790b918372b63bf361b643f9beb32eb Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Wed, 20 Sep 2023 17:09:56 +0100 Subject: [PATCH 05/15] unit tests in progress Signed-off-by: leanne.laceybyrne@eliatra.com --- .../apps/customerror/test/custom-error.test.tsx | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index 766232df2..e211135b8 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -25,14 +25,14 @@ describe('Custom error test', () => { const component = shallow( - ); + /> + ); expect(component).toMatchSnapshot(); }); -}) \ No newline at end of file +}) From f2b1f972a7211101379b905076fba3016ea8711d Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Thu, 21 Sep 2023 16:56:53 +0100 Subject: [PATCH 06/15] wip unit tests in progress Signed-off-by: leanne.laceybyrne@eliatra.com --- .../__snapshots__/custom-error.test.tsx.snap | 38 +++++++++++++++++++ .../customerror/test/custom-error.test.tsx | 4 -- 2 files changed, 38 insertions(+), 4 deletions(-) create mode 100644 public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap diff --git a/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap b/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap new file mode 100644 index 000000000..a8f273f33 --- /dev/null +++ b/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap @@ -0,0 +1,38 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`Custom error test renders 1`] = ` + + + +

+ Title +

+ + + + Sub Title + + + + Logout + + +`; diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index e211135b8..a0ea31d5a 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -16,10 +16,6 @@ import { shallow } from 'enzyme'; import React from 'react'; import { CustomErrorPage } from '../custom-error'; -jest.mock('../utils', () => ({ - logout: jest.fn(), -})); - describe('Custom error test', () => { it('renders', () => { const component = shallow( From 0a19f52477128c196cf049daae0199485b8b7e4e Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Thu, 21 Sep 2023 17:44:47 +0100 Subject: [PATCH 07/15] wip unit tests Signed-off-by: leanne.laceybyrne@eliatra.com --- public/apps/customerror/test/custom-error.test.tsx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index a0ea31d5a..c1119bc67 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -19,8 +19,12 @@ import { CustomErrorPage } from '../custom-error'; describe('Custom error test', () => { it('renders', () => { const component = shallow( - { ); expect(component).toMatchSnapshot(); }); -}) +}); From b0b28455562a8eb693d54e316cd0716cc06264e4 Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Mon, 25 Sep 2023 11:33:22 +0100 Subject: [PATCH 08/15] wip unit tests Signed-off-by: leanne.laceybyrne@eliatra.com --- .../__snapshots__/custom-error.test.tsx.snap | 2 +- .../customerror/test/custom-error.test.tsx | 81 ++++++++++++++++++- 2 files changed, 80 insertions(+), 3 deletions(-) diff --git a/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap b/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap index a8f273f33..ab5cdab5d 100644 --- a/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap +++ b/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`Custom error test renders 1`] = ` +exports[`Custom error test renders the button on the error page 1`] = ` diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index c1119bc67..769d55194 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -15,9 +15,49 @@ import { shallow } from 'enzyme'; import React from 'react'; import { CustomErrorPage } from '../custom-error'; +import { error } from "console"; +import { render, screen, cleanup } from "@testing-library/react"; +// Importing the jest testing library +import '@testing-library/jest-dom' +import { ClientConfigType } from '../../../types'; + +// afterEach function runs after each test suite is executed +afterEach(() => { + cleanup(); // Resets the DOM after each test suite +}); + + +// describe("Error page ", () => { +// it('renders', () => { +// const logout = shallow( +// +// ); +// const button = screen.getByTestId("button"); + +// // Test 1 +// test("Button Rendering", () => { +// expect(button).toBeInTheDocument(); +// }) + +// // Test 2 +// test("Button Text", () => { +// expect(button).toHaveTextContent("Logout"); +// }) +// }) +// }); + +const configUiDefault = { + basicauth: { + login: { + showbrandimage: true, + }, + }, +}; describe('Custom error test', () => { - it('renders', () => { + it('renders the button on the error page', () => { const component = shallow( { }} /> ); + + // const logoutButton = component.getByRole('button') + // error('logout button', logoutButton) + //expect(component.find('[EuiButton="Logout"]') expect(component).toMatchSnapshot(); + //.contains('render error')).toBeTruthy(); + // expect(component).value.toMatch(/Logout/) + // expect(component).toMatchSnapshot(); + + describe('event trigger testing', () => { + let component; + const setState = jest.fn(); + const useState = jest.spyOn(React, 'useState'); + const config: ClientConfigType = { + ui: configUiDefault, + auth: { + type: 'basicauth', + }, + }; + beforeEach(() => { + useState.mockImplementation((initialValue) => [initialValue, setState]); + component = shallow( + + ); + }); + }); }); -}); +}); \ No newline at end of file From 7f7a2516fd67a7162d9b8f5adaa094904785086d Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Mon, 25 Sep 2023 12:17:29 +0100 Subject: [PATCH 09/15] wip unit tests, linting fixed Signed-off-by: leanne.laceybyrne@eliatra.com --- .../customerror/test/custom-error.test.tsx | 36 ++++--------------- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index 769d55194..481b671c1 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -15,18 +15,15 @@ import { shallow } from 'enzyme'; import React from 'react'; import { CustomErrorPage } from '../custom-error'; -import { error } from "console"; -import { render, screen, cleanup } from "@testing-library/react"; -// Importing the jest testing library -import '@testing-library/jest-dom' +import { cleanup } from '@testing-library/react'; +import '@testing-library/jest-dom'; import { ClientConfigType } from '../../../types'; - + // afterEach function runs after each test suite is executed afterEach(() => { - cleanup(); // Resets the DOM after each test suite + cleanup(); }); - // describe("Error page ", () => { // it('renders', () => { // const logout = shallow( @@ -74,16 +71,9 @@ describe('Custom error test', () => { /> ); - // const logoutButton = component.getByRole('button') - // error('logout button', logoutButton) - //expect(component.find('[EuiButton="Logout"]') expect(component).toMatchSnapshot(); - //.contains('render error')).toBeTruthy(); - // expect(component).value.toMatch(/Logout/) - // expect(component).toMatchSnapshot(); describe('event trigger testing', () => { - let component; const setState = jest.fn(); const useState = jest.spyOn(React, 'useState'); const config: ClientConfigType = { @@ -94,22 +84,8 @@ describe('Custom error test', () => { }; beforeEach(() => { useState.mockImplementation((initialValue) => [initialValue, setState]); - component = shallow( - - ); + // add addtional funtionality to test the logout button click and its reroute }); }); }); -}); \ No newline at end of file +}); From 8a43b03fa20187e09b70e248ead3c7185d9d95e3 Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Tue, 26 Sep 2023 09:11:31 +0100 Subject: [PATCH 10/15] unit tests wip Signed-off-by: leanne.laceybyrne@eliatra.com --- .../customerror/test/custom-error.test.tsx | 81 ++++++++++--------- 1 file changed, 41 insertions(+), 40 deletions(-) diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index 481b671c1..c923c6bd1 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -17,34 +17,11 @@ import React from 'react'; import { CustomErrorPage } from '../custom-error'; import { cleanup } from '@testing-library/react'; import '@testing-library/jest-dom'; -import { ClientConfigType } from '../../../types'; -// afterEach function runs after each test suite is executed afterEach(() => { cleanup(); }); -// describe("Error page ", () => { -// it('renders', () => { -// const logout = shallow( -// -// ); -// const button = screen.getByTestId("button"); - -// // Test 1 -// test("Button Rendering", () => { -// expect(button).toBeInTheDocument(); -// }) - -// // Test 2 -// test("Button Text", () => { -// expect(button).toHaveTextContent("Logout"); -// }) -// }) -// }); - const configUiDefault = { basicauth: { login: { @@ -53,9 +30,13 @@ const configUiDefault = { }, }; +const mockLogout = jest.fn(); + + + describe('Custom error test', () => { - it('renders the button on the error page', () => { - const component = shallow( + it('renders and clicks the button on the error page', () => { + const wrapper = shallow( { /> ); - expect(component).toMatchSnapshot(); + // jest.mock('../custom-error.tsx', () => { + // logout: mockLogout + // }); + + // const logoutButton = wrapper.find(`[data-testid="error-logout-button"]`).hostNodes(); + // logoutButton.simulate("onClick") + // expect(mockLogout).toHaveBeenCalled(); + + expect(wrapper).toMatchSnapshot(); + + // describe('event trigger testing', () => { + // const setState = jest.fn(); + // const useState = jest.spyOn(React, 'useState'); + // const config: ClientConfigType = { + // ui: configUiDefault, + // auth: { + // type: 'basicauth', + // }, + // }; + // beforeEach(() => { + // useState.mockImplementation((initialValue) => [initialValue, setState]); + // // add addtional funtionality to test the logout button click and its reroute + // }); + // }); - describe('event trigger testing', () => { - const setState = jest.fn(); - const useState = jest.spyOn(React, 'useState'); - const config: ClientConfigType = { - ui: configUiDefault, - auth: { - type: 'basicauth', - }, - }; - beforeEach(() => { - useState.mockImplementation((initialValue) => [initialValue, setState]); - // add addtional funtionality to test the logout button click and its reroute - }); - }); + // describe("should call logout function", () => { + // const logOutUser = jest.fn(); + + // const { getByTestId } = render( + // + // ); + + // fireEvent.click(getByTestId('error-logout-button')); + + // expect(logOutUser).toHaveBeenCalled(); + // }); }); }); From 16cac6baf9075aa10cd7e8773aa24ce18137f898 Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Tue, 26 Sep 2023 11:00:07 +0100 Subject: [PATCH 11/15] unit tests covering line 49, logout button click and linting fixed in tsx and .test.tsx files Signed-off-by: leanne.laceybyrne@eliatra.com --- public/apps/customerror/custom-error.tsx | 8 ++- .../customerror/test/custom-error.test.tsx | 53 ++++++------------- 2 files changed, 22 insertions(+), 39 deletions(-) diff --git a/public/apps/customerror/custom-error.tsx b/public/apps/customerror/custom-error.tsx index fab81c218..973068add 100644 --- a/public/apps/customerror/custom-error.tsx +++ b/public/apps/customerror/custom-error.tsx @@ -46,7 +46,12 @@ export function CustomErrorPage(props: CustomErrorDeps) { {props.subtitle} - logout(props.http, '')} fullWidth> + logout(props.http, '')} + data-test-subj="error-logout-button" + fullWidth + > Logout @@ -75,3 +80,4 @@ export async function renderPage( ); return () => ReactDOM.unmountComponentAtNode(params.element); } +export { EuiButton }; diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index c923c6bd1..dc03c669b 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -17,6 +17,8 @@ import React from 'react'; import { CustomErrorPage } from '../custom-error'; import { cleanup } from '@testing-library/react'; import '@testing-library/jest-dom'; +import { EuiButton } from '../custom-error'; +import { logout } from '../../account/utils'; afterEach(() => { cleanup(); @@ -30,12 +32,18 @@ const configUiDefault = { }, }; -const mockLogout = jest.fn(); - +describe('Custom error test', () => { + let component; + beforeEach(() => { + component = shallow( + + Logout + + ); + }); -describe('Custom error test', () => { - it('renders and clicks the button on the error page', () => { + it('renders and clicks the button on the error page', () => { const wrapper = shallow( { /> ); - // jest.mock('../custom-error.tsx', () => { - // logout: mockLogout - // }); - - // const logoutButton = wrapper.find(`[data-testid="error-logout-button"]`).hostNodes(); - // logoutButton.simulate("onClick") - // expect(mockLogout).toHaveBeenCalled(); - expect(wrapper).toMatchSnapshot(); - // describe('event trigger testing', () => { - // const setState = jest.fn(); - // const useState = jest.spyOn(React, 'useState'); - // const config: ClientConfigType = { - // ui: configUiDefault, - // auth: { - // type: 'basicauth', - // }, - // }; - // beforeEach(() => { - // useState.mockImplementation((initialValue) => [initialValue, setState]); - // // add addtional funtionality to test the logout button click and its reroute - // }); - // }); - - // describe("should call logout function", () => { - // const logOutUser = jest.fn(); - - // const { getByTestId } = render( - // - // ); - - // fireEvent.click(getByTestId('error-logout-button')); - - // expect(logOutUser).toHaveBeenCalled(); - // }); + component.find('[data-test-subj="error-logout-button"]').simulate('onClick', { + preventDefault: () => {}, + }); }); }); From cd139056244c7704f7cda2e9671d4d4a2f1cb568 Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Tue, 26 Sep 2023 11:42:07 +0100 Subject: [PATCH 12/15] fix obsolete snapshot Signed-off-by: leanne.laceybyrne@eliatra.com --- .../customerror/test/__snapshots__/custom-error.test.tsx.snap | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap b/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap index ab5cdab5d..f48552234 100644 --- a/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap +++ b/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`Custom error test renders the button on the error page 1`] = ` +exports[`Custom error test renders and clicks the button on the error page 1`] = ` @@ -28,6 +28,7 @@ exports[`Custom error test renders the button on the error page 1`] = ` size="s" /> Date: Tue, 26 Sep 2023 15:03:27 +0100 Subject: [PATCH 13/15] peter confirmed code coverage is complete - unit tests complete Signed-off-by: leanne.laceybyrne@eliatra.com --- .../test/__snapshots__/custom-error.test.tsx.snap | 2 +- public/apps/customerror/test/custom-error.test.tsx | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap b/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap index f48552234..ceb888fc1 100644 --- a/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap +++ b/public/apps/customerror/test/__snapshots__/custom-error.test.tsx.snap @@ -1,6 +1,6 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`Custom error test renders and clicks the button on the error page 1`] = ` +exports[`Custom error page test renders and clicks the button on the error page 1`] = ` diff --git a/public/apps/customerror/test/custom-error.test.tsx b/public/apps/customerror/test/custom-error.test.tsx index dc03c669b..18291c351 100644 --- a/public/apps/customerror/test/custom-error.test.tsx +++ b/public/apps/customerror/test/custom-error.test.tsx @@ -24,15 +24,7 @@ afterEach(() => { cleanup(); }); -const configUiDefault = { - basicauth: { - login: { - showbrandimage: true, - }, - }, -}; - -describe('Custom error test', () => { +describe('Custom error page test', () => { let component; beforeEach(() => { From c21f06eb0b40bf5ea8e6616f042f952a6e0ad1a6 Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Mon, 9 Oct 2023 15:52:11 +0100 Subject: [PATCH 14/15] trigger ci Signed-off-by: leanne.laceybyrne@eliatra.com --- public/apps/customerror/custom-error.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/public/apps/customerror/custom-error.tsx b/public/apps/customerror/custom-error.tsx index 973068add..4ec9156f1 100644 --- a/public/apps/customerror/custom-error.tsx +++ b/public/apps/customerror/custom-error.tsx @@ -63,6 +63,8 @@ export async function renderPage( params: AppMountParameters, config: ClientConfigType ) { + + ReactDOM.render( From 8f233259ff5a2ab69396d476a9036f50c0ce742a Mon Sep 17 00:00:00 2001 From: "leanne.laceybyrne@eliatra.com" Date: Mon, 9 Oct 2023 15:52:37 +0100 Subject: [PATCH 15/15] trigger ci Signed-off-by: leanne.laceybyrne@eliatra.com --- public/apps/customerror/custom-error.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/public/apps/customerror/custom-error.tsx b/public/apps/customerror/custom-error.tsx index 4ec9156f1..973068add 100644 --- a/public/apps/customerror/custom-error.tsx +++ b/public/apps/customerror/custom-error.tsx @@ -63,8 +63,6 @@ export async function renderPage( params: AppMountParameters, config: ClientConfigType ) { - - ReactDOM.render(