Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default value of IMAGE_SCRIPTS_URL in task-java-s2i #363

Open
anilabhabaral opened this issue Feb 26, 2025 · 0 comments
Open

Comments

@anilabhabaral
Copy link

anilabhabaral commented Feb 26, 2025

Issue:

In the task-java-s2i the default IMAGE_SCRIPTS_URL is /usr/libexec/s2i

    - name: IMAGE_SCRIPTS_URL
      type: string
      default: image:///usr/libexec/s2i     <---------     
      description: |
        Specify a URL containing the default assemble and run scripts for the builder image

But in all the latest OpenJDK Builder image the s2i IMAGE_SCRIPTS are available in this directory image:///usr/local/s2i .

For example in OpenJDK 17 builder image see the Dockerfile(line no 154): https://catalog.redhat.com/software/containers/ubi8/openjdk-17/618bdbf34ae3739687568813?container-tabs=dockerfile

            io.openshift.s2i.scripts-url="image:///usr/local/s2i" \

And in OpenJDK 11 builder image Dockerfile(line no 174): https://catalog.redhat.com/software/containers/ubi8/openjdk-11/5dd6a4b45a13461646f677f4?container-tabs=dockerfile

            io.openshift.s2i.scripts-url="image:///usr/local/s2i" \

Fix:

As per the above examples i think it would be better to make the default IMAGE_SCRIPTS_URL to image:///usr/local/s2i.

I will create a PR for this change.

@anilabhabaral anilabhabaral changed the title Change the IMAGE_SCRIPTS_URL in task-java-s2i Change the default value of IMAGE_SCRIPTS_URL in task-java-s2i Feb 26, 2025
anilabhabaral added a commit to anilabhabaral/tektoncd-catalog that referenced this issue Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant