Allow passing LokiStack storageClassName

[mffiedler]

To run the netobserv-perf automation on non-AWS clouds (or on 4.12 where the gp2 storageClass no longer exists), we should let the user pass the storageClassName for the LokiStack CRD. It can default to gp2.

cc: @nathan-weinberg

[nathan-weinberg]

cc: @memodi

[memodi]

@mffiedler - there seems to be default storageclass that cluster uses:

4.12

$ oc get storageclass -o=jsonpath='{.items[?(@.metadata.annotations.storageclass\.kubernetes\.io/is-default-class=="true")].metadata.name}'
gp3-csi

4.11:

$ oc get storageclass -o=jsonpath='{.items[?(@.metadata.annotations.storageclass\.kubernetes\.io/is-default-class=="true")].metadata.name}'
gp2

do you think a better approach would be to use the default cluster storageClass derived from above method?

As for user to be able to pass storageClassName, for our use case, I am trying to think what could be scenarios in which we could need other storage class? given that Loki is uploading flow logs to cloud providers object storage platform anyway.

For pipeline to work for other cloud providers, I created this task: https://issues.redhat.com/browse/NETOBSERV-582

[mffiedler]

Default would be great. Will the LokiStack use the default sc if you leave storageClassName unspecified? or if there is better way to take the default, that would be OK by me

[memodi]

Will the LokiStack use the default sc if you leave storageClassName unspecified?

Just checked, users must specify storageClass while creating LokiStack, no default values. We'll change our LokiStack manifests to use cluster default SC.