Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary banner notice of 1.8 CLI feature unavailability #89214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2025
@skrthomas skrthomas force-pushed the cli-release-warning-1.8 branch from 3e050d2 to 4cccdf2 Compare February 26, 2025 20:08
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2025
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 26, 2025

@skrthomas skrthomas force-pushed the cli-release-warning-1.8 branch from 4cccdf2 to 86fafa5 Compare February 26, 2025 20:34
@msherif1234
Copy link

/lgtm
hopefully this comment can be removed soon but this is the case as of now

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
Copy link

@KarieCook KarieCook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, A public facing reference Jira so the customer can track when the CLI is available would be a good addition if one exists

@skrthomas skrthomas requested a review from mcurry-rh February 26, 2025 21:23
@memodi
Copy link

memodi commented Feb 26, 2025

/label qe-approved

@skrthomas
Copy link
Contributor Author

This PR has been tagged for PM approval per change management guidelines. Seeking peer review ahead of time so we can move quickly with this notice.

@maxwelldb maxwelldb added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 26, 2025
@skrthomas skrthomas force-pushed the cli-release-warning-1.8 branch from 86fafa5 to 696b46e Compare February 26, 2025 21:39
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
Copy link

openshift-ci bot commented Feb 26, 2025

New changes are detected. LGTM label has been removed.

Comment on lines 49 to 52
[IMPORTANT]
===
The Network Observability 1.8 CLI updates are unavailable at this time. This is expected to resolve soon.
===
Copy link
Contributor

@maxwelldb maxwelldb Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Network Observability 1.8 CLI or Network Observability Operator 1.8 CLI?

Just confirming! I am ignorant and this could be a useless question.

e: Looks like it's fine as is just skimming live docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[IMPORTANT]
===
The Network Observability 1.8 CLI updates are unavailable at this time. This is expected to resolve soon.
===
[IMPORTANT]
====
The Network Observability 1.8 CLI updates are unavailable at this time. This issue is expected to resolve soon.
====

This is not rendering correctly at the moment. I think that should fix it.

Added a word to avoid an ambiguous pronoun.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a good question, RE Operator. The CLI is just Network observability CLI. It has some of the same functionality of the Operator but it is not the Operator. Its more like a CLI component that accompanies the Operator to make a "Network Observability tool"

Thanks for the word, good idea.

@maxwelldb maxwelldb added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 26, 2025
@skrthomas skrthomas force-pushed the cli-release-warning-1.8 branch from 696b46e to 1fcf768 Compare February 26, 2025 21:44
@skrthomas skrthomas force-pushed the cli-release-warning-1.8 branch from 1fcf768 to c152809 Compare February 27, 2025 01:20
Copy link

openshift-ci bot commented Feb 27, 2025

@skrthomas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants