Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Detect if the user to init on Tenant already has a project on OSO #1446

Open
xcoulon opened this issue Nov 22, 2017 · 3 comments
Open

Detect if the user to init on Tenant already has a project on OSO #1446

xcoulon opened this issue Nov 22, 2017 · 3 comments
Assignees
@xcoulon
Labels
area/user/tenant team/platform train/heather type/SDD-feature
Milestone
Sprint 151

Comments

@xcoulon
Copy link
Collaborator

xcoulon commented Nov 22, 2017 •
edited by qodfathr
Loading

Goal is to verify that the user to init on Tenant has no project on OSO prior to using OSIO, otherwise it would cause some problems during the tenant initialization (unable to create a new project in his account due to quota limits).
This verification could be done during the init (in which case, there would be an error returned if the user already has a project), or before, which requires a new endpoint

Parent Experience

#2129 Handling of pre-existing OpenShift Online Starter artifacts for new OpenShift.io users
@xcoulon xcoulon self-assigned this Nov 22, 2017
@kbsingh kbsingh mentioned this issue Nov 22, 2017
Open
2 tasks
@joshuawilson joshuawilson added this to the Platform Backlog milestone Nov 22, 2017
@xcoulon xcoulon modified the milestones: Platform Backlog, Sprint 141 Nov 23, 2017
@joshuawilson joshuawilson modified the milestones: Sprint 141, Sprint 143 Jan 3, 2018
@aslakknutsen
Copy link
Collaborator

API Draft/Flow discussed with UI @dgutride

POST /api/user/services

    409 Conflict 
        data.attributes
            msg: string
            quota: int
            namespaces: [
                "conflicted_namespace"
            ] 
        links
            delete: some_url

DELETE "links.delete"

    200 Ok

I think if you call POST again after DELETE, POST 'should' return 202 Accepted and the async init is in progress

GET /api/user/services

    200 OK

    this should contain the status etc if needed.

@aslakknutsen
Copy link
Collaborator

fabric8-services/fabric8-tenant#469

@joshuawilson joshuawilson modified the milestones: Sprint 143, Sprint 144 Jan 25, 2018
@qodfathr qodfathr mentioned this issue Jan 31, 2018
Open
1 task
@joshuawilson
Copy link
Member

what is the status on this?

xcoulon added a commit to xcoulon/fabric8-tenant that referenced this issue Mar 2, 2018
@xcoulon
Detect if the user to init on Tenant already has a project on OSO (OS…
16a895e 
…IO#1446)

Include option in User service to support custom HTTP transport
Rename vars in controller.Tenant to avoid collision with packages (`user` and `cluster`)
Add test on the controller.TenantController.Setup() method using go-vcr

Fixes openshiftio/openshift.io#1446

Signed-off-by: Xavier Coulon <[email protected]>
@joshuawilson joshuawilson removed this from the Sprint 145 milestone Mar 6, 2018
@joshuawilson joshuawilson added this to the Sprint 146 milestone Mar 6, 2018
xcoulon added a commit to xcoulon/fabric8-tenant that referenced this issue Mar 8, 2018
@xcoulon
Detect if the user to init on Tenant already has a project on OSO (OS…
e04f797 
…IO#1446)

Include option in User service to support custom HTTP transport
Rename vars in controller.Tenant to avoid collision with packages (`user` and `cluster`)
Add test on the controller.TenantController.Setup() method using go-vcr

Fixes openshiftio/openshift.io#1446

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/fabric8-tenant that referenced this issue Mar 8, 2018
@xcoulon
Detect if the user to init on Tenant already has a project on OSO (OS…
ce2c5a0 
…IO#1446)

Include option in User service to support custom HTTP transport
Rename vars in controller.Tenant to avoid collision with packages (`user` and `cluster`)
Add test on the controller.TenantController.Setup() method using go-vcr
Add a function in `openshift` pkg to retrieve the name of the user's projects (and factorize
the code to perform the GET request on the Openshift API endpoint)

Fixes openshiftio/openshift.io#1446

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/fabric8-tenant that referenced this issue Mar 9, 2018
@xcoulon
Detect if the user to init on Tenant already has a project on OSO (OS…
57b2b97 
…IO#1446)

Add function to list projects on OSO for the user, given his/her OSO token.
Check that there's no project, or a single project named after the user.
Include option in User service to support custom HTTP transport.
Rename vars in controller.Tenant to avoid collision with packages (`user` and `cluster`).
Add test on the controller.TenantController.Setup() method using `go-vcr`.
Add a function in `openshift` pkg to retrieve the name of the user's projects (and factorize
the code to perform the GET request on the Openshift API endpoint).

Fixes openshiftio/openshift.io#1446

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/fabric8-tenant that referenced this issue Mar 9, 2018
@xcoulon
Detect if the user to init on Tenant already has a project on OSO (OS…
12f0792 
…IO#1446)

Add function to list projects on OSO for the user, given his/her OSO token.
Check that there's no project, or a single project named after the user.
Include option in User service to support custom HTTP transport.
Rename vars in controller.Tenant to avoid collision with packages (`user` and `cluster`).
Add test on the controller.TenantController.Setup() method using `go-vcr`.
Add a function in `openshift` pkg to retrieve the name of the user's projects (and factorize
the code to perform the GET request on the Openshift API endpoint).

Also: use encoded token in the go-vcr recording for TestResolveServiceAccountToken

Fixes openshiftio/openshift.io#1446

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/fabric8-tenant that referenced this issue Mar 9, 2018
@xcoulon
Detect if the user to init on Tenant already has a project on OSO (OS…
bb40a68 
…IO#1446)

Add function to list projects on OSO for the user, given his/her OSO token.
Check that there's no project, or a single project named after the user.
Include option in User service to support custom HTTP transport.
Rename vars in controller.Tenant to avoid collision with packages (`user` and `cluster`).
Add test on the controller.TenantController.Setup() method using `go-vcr`.
Add a function in `openshift` pkg to retrieve the name of the user's projects (and factorize
the code to perform the GET request on the Openshift API endpoint).

Also: use encoded token in the go-vcr recording for TestResolveServiceAccountToken

Fixes openshiftio/openshift.io#1446

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Mar 9, 2018
Closed
xcoulon added a commit to xcoulon/fabric8-tenant that referenced this issue Mar 9, 2018
@xcoulon
Detect if the user to init on Tenant already has a project on OSO (OS…
dc160d3 
…IO#1446)

Add function to list projects on OSO for the user, given his/her OSO token.
Check that there's no project,  otherwise, clean/remove all user's namespaces.
Include option in User service to support custom HTTP transport.
Rename vars in controller.Tenant to avoid collision with packages (`user` and `cluster`).
Add test on the controller.TenantController.Setup() method using `go-vcr`.
Add a function in `openshift` pkg to retrieve the name of the user's projects (and factorize
the code to perform the GET request on the Openshift API endpoint).

Also: use encoded token in the go-vcr recording for TestResolveServiceAccountToken

Fixes openshiftio/openshift.io#1446

Signed-off-by: Xavier Coulon <[email protected]>
@joshuawilson joshuawilson modified the milestones: Sprint 146, Sprint 147 Mar 27, 2018
@xcoulon xcoulon modified the milestones: Platform Backlog, Sprint 149 May 14, 2018
@joshuawilson joshuawilson modified the milestones: Sprint 149, Sprint 150 May 29, 2018
@joshuawilson joshuawilson modified the milestones: Sprint 150, Sprint 151 Jun 21, 2018
@ibuziuk ibuziuk mentioned this issue Jun 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xcoulon xcoulon

Labels
area/user/tenant team/platform train/heather type/SDD-feature
Projects
None yet
Milestone
Sprint 151
Development

No branches or pull requests
3 participants
@aslakknutsen @xcoulon @joshuawilson