Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Status of Closed Changesets in Replication Files #1150

Open
pa5cal opened this issue Aug 25, 2024 · 3 comments
Open

Inconsistent Status of Closed Changesets in Replication Files #1150

pa5cal opened this issue Aug 25, 2024 · 3 comments

Comments

@pa5cal
Copy link

pa5cal commented Aug 25, 2024

In recent months and years, I have encountered several rare instances where closed changesets are not reflected as such in the changeset replication files.

Specifically, these changesets are listed with attributes such as created_at="..." and open="true" in the replication files, despite being closed in subsequent diff updates.

Here are three examples from yesterday:

Unless I have overlooked something, none of the three changesets mentioned here will be listed as closed in a later replication file. As I understand it, however, this should not be allowed to happen because, at least on the basis of the replication diffs, the changeset is never marked as closed.

@tomhughes
Copy link
Member

Sounds like a bug in the changeset dumper rather than an operational issue.

Looking at the code everything except detection of new changesets (which is based on id) is essentially heuristic because there's no other way to do it, so it's just looking at everything closed or commented on in the last period based on time which means there is the potential for a small window between runs that isn't picked up.

@pnorman
Copy link
Collaborator

pnorman commented Aug 26, 2024

none of the three changesets mentioned here will be listed as closed in a later replication file

Can you double-check this?

@pa5cal
Copy link
Author

pa5cal commented Aug 28, 2024

none of the three changesets mentioned here will be listed as closed in a later replication file

Can you double-check this?

I've checked that the changesets listed above are not contained in the linked and following replication file. What I have not explicitly checked is whether the changesets mentioned were published as closed in a replication file much later in the day.

But my assumption would be: If the changesets were distributed as closed, they would also have been closed in my changeset DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants