Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewing HVAC Systems Control view resets Controller:MechanicalVentilation System Outdoor Air Method #634

Closed
eringold opened this issue Sep 25, 2023 · 1 comment · Fixed by #646
Labels
Triage Issue needs to be assessed and labeled, further information on reported might be needed

Comments

@eringold
Copy link
Contributor

Issue overview

Loading a model with a Controller:MechanicalVentilation with 'System Outdoor Air Method' set to 'Standard62.1VentilationRateProcedureWithLimit' and navigating to the HVAC Systems Control tab will cause that input to be reset.

Expected Behavior

Input should be retained.

Steps to Reproduce

  1. Create and save a model with an AirLoopHVAC with OA System and Controller:MechanicalVentilation with System Outdoor Air Method set to 'Standard62.1VentilationRateProcedureWithLimit'.
  2. Open model in OSApp, navigate to HVAC Systems tab, Control view. Model change indicator (asterisk by filename) will appear.
  3. Save as, do file compare with original.

Possible Solution

Issue very similar to #379, therefore I suspect the fix will involve updating the addItem calls to ventilationCalcMethodComboBox:

ventilationCalcMethodComboBox->setEnabled(false);
ventilationCalcMethodComboBox->addItem("Zone Sum", "ZoneSum");
ventilationCalcMethodComboBox->addItem("Ventilation Rate Procedure", "VentilationRateProcedure");
ventilationCalcMethodComboBox->addItem("Indoor Air Quality Procedure", "IndoorAirQualityProcedure");
ventilationCalcMethodComboBox->addItem("Proportional Control", "ProportionalControl");
ventilationCalcMethodComboBox->setVisible(false);

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): Window 10
  • Version of OpenStudioApplication (if using an intermediate build, include SHA): 1.6.0
@eringold eringold added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Sep 25, 2023
@jmarrec
Copy link
Collaborator

jmarrec commented Nov 23, 2023

@eringold Are you still planning on providing a fix for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage Issue needs to be assessed and labeled, further information on reported might be needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants