Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save username and display name in local storage #12

Closed
dpocock opened this issue Mar 2, 2014 · 1 comment
Closed

save username and display name in local storage #12

dpocock opened this issue Mar 2, 2014 · 1 comment

Comments

@dpocock
Copy link
Member

dpocock commented Mar 2, 2014

JSCommunicator provides a way for users to log in with arbitrary SIP credentials (see the way it is used at https://rtc.debian.org )

Each time a user visits the site, they have to type

  • their display name (e.g. Daniel Pocock)
  • their SIP address (e.g. [email protected])
  • their password

We should avoid keeping the user password in any cache or local storage. However, maybe the display name and SIP address can be saved in local storage. It may be a good idea to provide a checkbox where the user can confirm that they want those details remembered in the browser they are using.

dpocock pushed a commit that referenced this issue Aug 13, 2014
organizing components display
@dpocock
Copy link
Member Author

dpocock commented Aug 16, 2014

This has been implemented in Juliana's commit.

Note that if a username or display name is provided in the config file, that will take priority and cached values will not appear in the login form.

This logic should also ensure that in situations where no login form is displayed (because the password is preconfigured), arbitrary values from the local storage will not conflict with the values mandated by the configuration.

One side effect is that the boxes can no longer be pre-configured to say "Your name here" or some other hint.

The remember-me checkbox could be improved further by #49, #50 and #51

@dpocock dpocock closed this as completed Aug 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant