Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bosses don't have coldown #3089

Closed
2 of 5 tasks
Regeton5306 opened this issue Nov 9, 2024 · 4 comments
Closed
2 of 5 tasks

Bosses don't have coldown #3089

Regeton5306 opened this issue Nov 9, 2024 · 4 comments
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@Regeton5306
Copy link

Priority

Medium

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

I test the bosses and they give the following error in the console
and after defeating the boss, I leave the room and can repeat the boss countless times
In fact, I tried with many bosses, and none of them have a cooldown before killing them again. All the ones I tested could be repeated instantly: bosses from Grave Danger, Forgotten Knowledge, Feaster of Soul, War Soul.

canary-main\data-otservbr-global/scripts\quests\forgotten_knowledge\actions_dragonking_zyrtarch.lua:callback`
Function: PlayerFunctions::luaPlayerSetStorageValue
Error Description: Storage key is nil
Stack Trace:
Storage key is nil
stack traceback:
[C]: in function 'setStorageValue'
...ests\forgotten_knowledge\actions_dragonking_zyrtarch.lua:37: in function <...ests\forgotten_knowledge\actions_dragonking_zyrtarch.lua:16>

canary-main\data-otservbr-global/scripts\quests\forgotten_knowledge\actions_lady_tenebris.lua:callback
Function: PlayerFunctions::luaPlayerSetStorageValue
Error Description: Storage key is nil
Stack Trace:
Storage key is nil
stack traceback:
[C]: in function 'setStorageValue'
...pts\quests\forgotten_knowledge\actions_lady_tenebris.lua:28: in function <...pts\quests\forgotten_knowledge\actions_lady_tenebris.lua:9>

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Regeton5306 Regeton5306 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 9, 2024
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Nov 9, 2024
@FelipePaluco
Copy link
Contributor

If you are testing with Admin (god), admin have no cooldown.

@Regeton5306
Copy link
Author

If you are testing with Admin (god), admin have no cooldown.

No, I made them with a new account that doesn’t have admin rights or any other kind of permissions.

@libergod
Copy link

Hello, I Tested with Scarlett, Duke Krule and Faceless, and all are working fine.

image

Lady Tenebris and Dragon King don't have the storage value set in lib/core/storages.lua; this is probably because it's not yet in the new style of script. (such as Duke Krule or Faceless Bane).

@htc16
Copy link
Contributor

htc16 commented Nov 18, 2024

This has already been corrected: #3049
And #3042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

5 participants