Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug no-logout #3101

Closed
2 of 5 tasks
htc16 opened this issue Nov 11, 2024 · 2 comments · Fixed by #3223
Closed
2 of 5 tasks

Bug no-logout #3101

htc16 opened this issue Nov 11, 2024 · 2 comments · Fixed by #3223
Labels
Priority: Low Minor impact Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@htc16
Copy link
Contributor

htc16 commented Nov 11, 2024

Priority

Low

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

If you put the character to train in a trainer for example, and open a STORE or Wheel of Destiny window, leaving these windows open, it is possible to close the X client and the character will remain connected and training indefinitely without logging out.

What OS are you seeing the problem on?

Windows

Code of Conduct

  • I agree to follow this project's Code of Conduct
@htc16 htc16 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 11, 2024
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels Nov 11, 2024
@htc16 htc16 changed the title Bug sem logout Bug no-logout Nov 11, 2024
@murilo09 murilo09 linked a pull request Jan 8, 2025 that will close this issue
feat: login and disconnect protection #3223
Merged
@murilo09
Copy link
Contributor

murilo09 commented Jan 8, 2025 •
edited
Loading

It is not a bug, but the player should stop attacking.
Test the linked PR, please.
X-Logging

@murilo09 murilo09 removed the Status: Pending Test This PR or Issue requires more testing label Jan 8, 2025
@htc16
Copy link
Contributor Author

htc16 commented Jan 9, 2025 •
edited
Loading

It is not a bug, but the player should stop attacking. Test the linked PR, please. X-Logging

Hello!

Sorry for the delay, but my year started off very hectic, including my wife being pregnant, so I'm a bit busy.

Ok, thanks, and I've already pulled it out to test it out on the base, I'll bring you feedback on it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Minor impact Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: login and disconnect protection opentibiabr/canary
2 participants
@htc16 @murilo09