Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentracing directive behavior in http vs location block #466

Open
phillipuniverse opened this issue Jun 28, 2023 · 0 comments
Open

Opentracing directive behavior in http vs location block #466

phillipuniverse opened this issue Jun 28, 2023 · 0 comments

Comments

@phillipuniverse
Copy link

I have some kind of weird behavior, and I'm not sure if this is intended or not. Here is a simple example of nginx.conf:

http {
load_module modules/ngx_http_opentracing_module.so;

events {}

http {
  opentracing on;

  opentracing_load_tracer /usr/local/lib/libdd_opentracing_plugin.so /etc/datadog-config.json;
  upstream backend {
    server app-service:9001;
  }

  server {
    error_log /var/log/nginx/debug.log debug;
    listen 8080;
    server_name localhost;

    location = /no-tracing {
        opentracing off;
        proxy_pass http://backend;
    }

    location = / {
      proxy_pass http://backend;
      opentracing_propagate_context;
    }
    location = 
  }
}

In this configuration scenario, I have opentracing on at the http level, but opentracing off at the location level. So my question is if I hit /no-tracing, is the expectation that request is traced or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant