Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode to site #1168

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add dark mode to site #1168

wants to merge 1 commit into from

Conversation

lukewarlow
Copy link
Collaborator

No description provided.

@lukewarlow
Copy link
Collaborator Author

These colours have currently mostly been picked at random based on my perception of their contrast so its possible they dont meet requirements (particularly some of the links look slightly dark compared to others so need to check that).

But I think it's a big win having dark mode.

Copy link
Collaborator

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me, but I'm definitely not an expert in this area. I'll click Approve, but it'd be good to get someone more authoritative to review, maybe?

@lukewarlow
Copy link
Collaborator Author

@gregwhitworth do you have thoughts on the use of modern styling such as light-dark() Vs using preference media queries (basically what browser support do we care about?)

Also do you have thoughts on this change in general.

@gregwhitworth
Copy link
Member

@lukewarlow first off thanks for tackling this. Looking at a few of the pages we have contrast issues that will have to be addressed to land this. The component matrix:

image

Code blocks. Here is dark mode:

image

Versus light mode:

image

The anatomy aren't visible due to leveraging transparency and assuming a white background:

image

The .note classes likewise end up with poor contrast:

image

Same with the Slider "Parts and Concepts" table

image

Looking at the various High Contrast solutions and or Color Pages they seem fine. So I think if you tweak the above two we should be in a good spot.

Copy link
Member

@gregwhitworth gregwhitworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See prior comment, a few scenarios end up with poor contrast due to these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants