From cc64ecf2a275fda54abda73bec1ccb2d3b539d72 Mon Sep 17 00:00:00 2001 From: Xinding Wei Date: Fri, 4 Oct 2024 10:47:11 -0700 Subject: [PATCH] Fix comments & naming --- stark-backend/src/keygen/v2/mod.rs | 10 +++++----- stark-backend/src/prover/v2/mod.rs | 1 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/stark-backend/src/keygen/v2/mod.rs b/stark-backend/src/keygen/v2/mod.rs index 6995f3a871..3ed904a5cd 100644 --- a/stark-backend/src/keygen/v2/mod.rs +++ b/stark-backend/src/keygen/v2/mod.rs @@ -17,7 +17,7 @@ use crate::{ pub mod types; pub(crate) mod view; -struct AIRKeygenBuilder<'a, SC: StarkGenericConfig> { +struct AirKeygenBuilder<'a, SC: StarkGenericConfig> { air: &'a dyn AnyRap, prep_keygen_data: PrepKeygenData, interaction_chunk_size: Option, @@ -28,7 +28,7 @@ struct AIRKeygenBuilder<'a, SC: StarkGenericConfig> { pub struct MultiStarkKeygenBuilderV2<'a, SC: StarkGenericConfig> { pub config: &'a SC, /// Information for partitioned AIRs. - partitioned_airs: Vec>, + partitioned_airs: Vec>, } impl<'a, SC: StarkGenericConfig> MultiStarkKeygenBuilderV2<'a, SC> { @@ -53,7 +53,7 @@ impl<'a, SC: StarkGenericConfig> MultiStarkKeygenBuilderV2<'a, SC> { air: &'a dyn AnyRap, interaction_chunk_size: Option, ) -> usize { - self.partitioned_airs.push(AIRKeygenBuilder::new( + self.partitioned_airs.push(AirKeygenBuilder::new( self.config.pcs(), air, interaction_chunk_size, @@ -124,10 +124,10 @@ impl<'a, SC: StarkGenericConfig> MultiStarkKeygenBuilderV2<'a, SC> { } } -impl<'a, SC: StarkGenericConfig> AIRKeygenBuilder<'a, SC> { +impl<'a, SC: StarkGenericConfig> AirKeygenBuilder<'a, SC> { fn new(pcs: &SC::Pcs, air: &'a dyn AnyRap, interaction_chunk_size: Option) -> Self { let prep_keygen_data = compute_prep_data_for_air(pcs, air); - AIRKeygenBuilder { + AirKeygenBuilder { air, prep_keygen_data, interaction_chunk_size, diff --git a/stark-backend/src/prover/v2/mod.rs b/stark-backend/src/prover/v2/mod.rs index 2567279ef7..205ac38f1b 100644 --- a/stark-backend/src/prover/v2/mod.rs +++ b/stark-backend/src/prover/v2/mod.rs @@ -105,7 +105,6 @@ impl<'c, SC: StarkGenericConfig> MultiTraceStarkProverV2<'c, SC> { (trace_views, committer.commit(traces)) }; - // Generate main trace commitments on the fly. // Commitments order: // - for each air: // - for each cached main trace