diff --git a/DESCRIPTION b/DESCRIPTION index eed751b..c3f9720 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: datavolley Title: Reading and Analyzing DataVolley Scout Files -Version: 1.7.2 +Version: 1.7.3 Authors@R: c(person("Ben", "Raymond", email = "ben@untan.gl", role = c("aut", "cre")), person("Adrien", "Ickowicz", role = "aut"), person("Tyler", "Widdison", role = "aut"), diff --git a/NEWS.md b/NEWS.md index 2b4d48a..44a9521 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,11 @@ +datavolley 1.7.3 +================ +- minor bugfixes + +datavolley 1.7.1 +================ +- the evaluation string used for a set with a "/" evaluation code has been changed from "Error (reach over net)" to just "Error" for consistency with other skills (applies to files using VolleyMetrics conventions only) + datavolley 1.7.0 ================ - fixes to support files using sideout scoring diff --git a/R/plays.R b/R/plays.R index defce4c..291c998 100644 --- a/R/plays.R +++ b/R/plays.R @@ -1007,8 +1007,8 @@ parse_code <- function(code, meta, evaluation_decoder, code_line_num, full_lines } ## fill in player_name and player_id from player_number idx <- !is.na(out_player_number) - out_player_name[idx] <- get_player_name(out_team[idx],out_player_number[idx],meta) - out_player_id[idx] <- get_player_id(out_team[idx],out_player_number[idx],meta) + out_player_name[idx] <- get_player_name(out_team[idx], out_player_number[idx], meta) + out_player_id[idx] <- get_player_id(out_team[idx], out_player_number[idx], meta) dudidx <- (!is.na(out_player_number) & is.na(out_player_name)) | grepl("unknown player", out_player_name, ignore.case = TRUE) if (any(dudidx)) msgs <- collect_messages(msgs,paste0("Player number ",out_player_number[dudidx]," could not be resolved to a player name/id"),code_line_num[dudidx],full_lines[dudidx],severity=2)