Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Allow to perform mass upgrade of devices by their group #213

Open
nemesifier opened this issue Nov 22, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@nemesifier
Copy link
Member

nemesifier commented Nov 22, 2022

OpenWISP Controller has recently introduced the concept of Groups. It would be great to allow to upgrade all the devices related to a group with a mass upgrade operation. We could add an optional group field on the mass upgrade model which if filled would cause the upgrade operation to work only on the devices related to that group.

There would be a few things to change to make sure the dry run method works consistently. In the admin we have to show the group field as an autocomplete field and add a filter by group (also autocomplete) in the admin list.

The internal logic of models and methods shall also take into account this change and if the group is defined only devices of that group must be upgraded.

We will add to add validation logic in the model to ensure that the group of a mass upgrade operation matches its organization, there's already plenty of similar logic in different openwisp modules, see also: https://github.com/openwisp/openwisp-users/blob/master/openwisp_users/mixins.py#L11 .

We must remember to not forget to add mention of this feature in the README (intro and mass upgrade explanation section).

@nemesifier nemesifier added the enhancement New feature or request label Nov 22, 2022
@nemesifier nemesifier changed the title [feature] Allow to upgrade device groups [feature] Allow to perform mass upgrade of devices by their group Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant