You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While doing some testing I hit VERIFY(list_is_empty(&lwb->lwb_itxs)); in zil_free_lwb while removing a physlcal disk from zpool.
So going through the code I noticed that zilog->zl_suspend is not protected by any lock. If there is a raise condition between zil_commit and zil_suspend, and zil_commit misses the update done by zil_suspend then we can end up in this situation. So I want to know if its ok to read zilog->zl_suspend without lock in zil_commit?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
While doing some testing I hit VERIFY(list_is_empty(&lwb->lwb_itxs)); in zil_free_lwb while removing a physlcal disk from zpool.
So going through the code I noticed that zilog->zl_suspend is not protected by any lock. If there is a raise condition between zil_commit and zil_suspend, and zil_commit misses the update done by zil_suspend then we can end up in this situation. So I want to know if its ok to read zilog->zl_suspend without lock in zil_commit?
Please let me know your thoughts.
Beta Was this translation helpful? Give feedback.
All reactions