Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: flag yellow for annotations that match case insensitive error #1472

Closed
codefromthecrypt opened this issue Jan 5, 2017 · 2 comments
Closed

UI: flag yellow for annotations that match case insensitive error #1472

codefromthecrypt opened this issue Jan 5, 2017 · 2 comments
Labels
enhancement ui Zipkin UI

Comments

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Jan 5, 2017 •
edited
Loading

Currently, we flag yellow a span that includes annotations that exact match error. In finagle and spring cloud sleuth, error is often a part of a format string, and might not be lowercase. I suggest we more leniently accept annotation highlighting to case insensitive contains.

@HancaiLi requested this in spring-cloud-sleuth
See openzipkin/openzipkin.github.io#52 for more complete description

Note, it is still best to strictly treat the tag (binary annotation) key "error" as that is used in search.
https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L218
@codefromthecrypt
Copy link
Member Author

cc @cburroughs in case you have time for this

codefromthecrypt pushed a commit that referenced this issue Jan 7, 2017
Flags yellow for annotations that match case insensitive error
d71f317 
Particularly, this flags existing finagle formatted errors, like so:
"Server Send Error: TimeoutException: socket timed out"

Fixes #1472
See openzipkin/openzipkin.github.io#52
@codefromthecrypt codefromthecrypt mentioned this issue Jan 7, 2017
Merged
@codefromthecrypt
Copy link
Member Author

#1475

codefromthecrypt pushed a commit that referenced this issue Jan 8, 2017
@adriancole
Flags yellow for annotations that match case insensitive error (#1475)
57788f8 
Particularly, this flags existing finagle formatted errors, like so:
"Server Send Error: TimeoutException: socket timed out"

Fixes #1472
See openzipkin/openzipkin.github.io#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ui Zipkin UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@codefromthecrypt