Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to investigate slight overshoot of phase stats #163

Open
seongsujeong opened this issue May 31, 2023 · 2 comments
Open

Need to investigate slight overshoot of phase stats #163

seongsujeong opened this issue May 31, 2023 · 2 comments
Labels
needs triage Issue requires triage to proceed

Comments

@seongsujeong
Copy link
Contributor

seongsujeong commented May 31, 2023

Checked for duplicates

Yes - I've already checked

Describe the bug

There was a slight overshoot in the stats of phase during pytest in circleCI. Especially, the minimum value of the phase was slightly smaller than -np.pi.
More information to be found at the comment in the PR below:

#162 (comment)

What did you expect?

I expected [...]

Reproducible steps

1.
2.
3.
...

Environment

- Version of this software [e.g. vX.Y.Z]
- Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
...
@seongsujeong seongsujeong added the needs triage Issue requires triage to proceed label May 31, 2023
@vbrancat
Copy link
Contributor

vbrancat commented Aug 2, 2023

@seongsujeong can you please verify if we need to investigate this issue?

@seongsujeong
Copy link
Contributor Author

Suspecting a truncation error. I’ll start taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue requires triage to proceed
Projects
None yet
Development

No branches or pull requests

2 participants