Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage] NvmeRemoteController* -> NvmeBackendController* #363

Open
artek-koltun opened this issue Sep 19, 2023 · 1 comment
Open

[storage] NvmeRemoteController* -> NvmeBackendController* #363

artek-koltun opened this issue Sep 19, 2023 · 1 comment
Assignees
@artek-koltun
Labels
Storage APIs or code related to storage area

Comments

@artek-koltun
Copy link
Contributor

At the moment, we have an empty backend_nvme_pcie.proto and backend_nvme_tcp.proto. However, it is planned to have fabrics and pcie in one backend service. Probably, rename of backend_nvme_tcp.proto to backend_nvme.proto and deletion of backend_nvme_pcie.proto makes sense.

Also, since we can connect to local pcie nvme drives by the service in backend_nvme_tcp.proto it might make sense to rename messages:
NvmeRemoteController* -> NvmeBackendController*
NvmeRemoteNamespace* -> NvmeBackendNamespace*

Additionally, see #343
@artek-koltun artek-koltun added the Storage APIs or code related to storage area label Sep 19, 2023
This was referenced Oct 5, 2023
Merged
Open
@artek-koltun
Copy link
Contributor Author

Files are renamed/deleted

Message renames are left

@artek-koltun artek-koltun self-assigned this Oct 5, 2023
@glimchb glimchb changed the title Make storage backend nvme file and content consistent with provided services [storage] NvmeRemoteController* -> NvmeBackendController* Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artek-koltun artek-koltun

Labels
Storage APIs or code related to storage area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artek-koltun