IPs in ARP table not sorted numerically

[xorbital]

Describe the bug
The ARP table sorts the IPs in this order:

• 192.168.1.1
• 192.168.1.11
• 192.168.1.2

To Reproduce
Steps to reproduce the behavior:
Go to Interfaces - Diagnostics - ARP table
Click on "IP" to sort via IP.

Expected behavior
The IPs should be sorted in numeric ascending / descending order

Screenshots

Relevant log files
(not applicable)

Additional context
It seems like the IPs are interpreted as a string while there should probably be some number sorting going on.

Environment
OPNsense 20.1.7-amd64

Thank you very much for your work on this project, I really appreciate it ❤️

[fichtner]

Just an idea, we could sort be aux value and push the hex representation into the GUI for JS to sort it numerically. Parsing the address format just for sorting isn’t a great approach even though some library or code already exists. Every bit of additional code might break or require maintenance down the road.

…

On 26. Jun 2020, at 15:45, xorbital ***@***.***> wrote:  Describe the bug The ARP table sorts the IPs in this order: 192.168.1.1 192.168.1.11 192.168.1.2 To Reproduce Steps to reproduce the behavior: Go to Interfaces - Diagnostics - ARP table Click on "IP" to sort via IP. Expected behavior The IPs should be sorted in numeric ascending / descending order Screenshots Relevant log files (not applicable) Additional context It seems like the IPs are interpreted as a string while there should probably be some number sorting going on. Environment OPNsense 20.1.7-amd64 Thank you very much for your work on this project, I really appreciate it ❤️ — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[AdSchellevis]

bootgrid doesn't support natural sorting (rstaib/jquery-bootgrid#419), in which case we should build an api which handles the data feed (like the model does) or extend bootdgrid, both options are unlikely to be implemented shortly. In the case of arp, one could reformat the addresses to zero padded (e.g. 192.168.001.001) in which case they would sort correct automatically, but might lead to other concerns.

[OPNsense-bot]

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository,
please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.

[pakair]

arp -n | sort -V produces ip-sorted output.