Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print KVM memslots related information #146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Print KVM memslots related information #146

wants to merge 2 commits into from

Conversation

SiddhiK29
Copy link
Member

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 17, 2025
brenns10
brenns10 requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@brenns10 brenns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few smaller comments. But I admit I'm not an expert, so I'll ask Joe to take a look at this as well.

@SiddhiK29 SiddhiK29 requested a review from brenns10 February 4, 2025 11:41
@joejin00
Copy link

joejin00 commented Feb 5, 2025

Please add below to the output:

  1. total pages for each vm
  2. translate the flag to string.

@SiddhiK29 SiddhiK29 force-pushed the test_mmslot branch 2 times, most recently from 0d15836 to 7856f1c Compare February 11, 2025 10:23
@SiddhiK29 SiddhiK29 requested a review from joejin00 February 11, 2025 11:10
joejin00
joejin00 reviewed Feb 11, 2025
View reviewed changes
@SiddhiK29
kvm: Print KVM memslots related information.
e5ee1c4 
Orabug: 37357370
Signed-off-by: Siddhi Katage <[email protected]>
@SiddhiK29 SiddhiK29 requested a review from joejin00 February 12, 2025 11:04
@joejin00
Copy link

Data structure in kernel and output is good to me.
Reviewed-By: Joe Jin [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brenns10 brenns10 Awaiting requested review from brenns10

@joejin00 joejin00 Awaiting requested review from joejin00

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiddhiK29 @joejin00 @brenns10