Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: add "ps" corelens module #44

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

SiddhiK29
Copy link
Member

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 6, 2023
Copy link
Member

@brenns10 brenns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just missing a few features that I enumerated in the comments.
Thanks!

@SiddhiK29 SiddhiK29 force-pushed the ps_mod branch 4 times, most recently from 65ddb41 to c3bc5b7 Compare December 19, 2023 12:21
@SiddhiK29 SiddhiK29 requested a review from brenns10 December 19, 2023 14:30
@SiddhiK29 SiddhiK29 force-pushed the ps_mod branch 3 times, most recently from cdba130 to 887d4f6 Compare December 20, 2023 11:16
Co-authored-by: Partha Sarathi Satapathy <[email protected]>
Signed-off-by: Siddhi Katage <[email protected]>
@brenns10
Copy link
Member

brenns10 commented Jan 8, 2024

Thanks for all the work on this! Looks good.

@brenns10 brenns10 merged commit b330c9a into oracle-samples:main Jan 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants