Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make service name the default choice #12

Open
gvenzl opened this issue Jul 10, 2024 · 3 comments
Open

Make service name the default choice #12

gvenzl opened this issue Jul 10, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@gvenzl
Copy link
Member

gvenzl commented Jul 10, 2024

Connecting to Oracle Database via SID is highly discouraged and for 99% of application use cases should no longer be required.

Hence it doesn't make much sense to have SID be the default selected choice and not the service name:

gvenzl@gvenzl-mac my-app % npm create @oracle/database-app -- --name 'my-todo' --template 'node-vanilla'
? Which database connection type would you like to choose? Basic Connection (Protocol, Hostname, Port, Service Name / SID)
? What is your database protocol? tcp
? What is your database hostname? localhost
? What is your database port? 1521
? Which service type would you like to use? (Use arrow keys)
❯ SID
  Service name

This should be the other way around, Service name should be the default.

@mig8447 mig8447 added the enhancement New feature or request label Jul 10, 2024
@cjbj
Copy link
Member

cjbj commented Jul 11, 2024

I'd argue that SID shouldn't be shown at all.

Also, the default service_name could be freepdb1.

And don't write passwords to clear text files...

@mig8447
Copy link
Member

mig8447 commented Jul 15, 2024

@cjbj We write the password to a "dotenv" file (See https://www.dotenv.org/docs/security/env ) which is pretty much a standard practice to store sensitive information in Node.js. We do ignore those files adding an entry for the .gitignore file so that they don't accidentally end up in the repositories. Would you suggest any other alternative?

@gvenzl
Copy link
Member Author

gvenzl commented Jul 18, 2024

I'm fine with not showing the SID option at all and defaulting to freepdb1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants