UploadRequest creates ObjectStorageClient when uploading request is processing.

[urunimi]

I don't think it is good idea to create ObjectStorageClient instance while uploading.

How about return error instantly if the client is not set?

I used long time to debug this issue and I can create a pull request.

oci-go-sdk/objectstorage/transfer/upload_manager_req_resp.go

Lines 144 to 157 in a172b32

	if request.ObjectStorageClient == nil {
	client, err := objectstorage.NewObjectStorageClientWithConfigurationProvider(common.DefaultConfigProvider())
	// default timeout is 60s which includes the time for reading the body
	// default timeout doesn't work for big file, here will use the default
	// 0s which means no timeout
	client.HTTPClient = &http.Client{}
	if err != nil {
	return err
	}
	request.ObjectStorageClient = &client
	}

func New() (CloudStorage, error) {
	// I used `ConfigurationProviderEnvironmentVariables` to create the configuration.
	conf := common.ConfigurationProviderEnvironmentVariables("oci", "")
	// It passes `IsConfigurationProviderValid`. 
	c, err := objectstorage.NewObjectStorageClientWithConfigurationProvider(conf)
	// ...
}

func (s *ociObjectStorage) Upload(objectName string, data []byte) error {
	// ...
	uploadManager := transfer.NewUploadManager()

	req := transfer.UploadStreamRequest{
		UploadRequest: transfer.UploadRequest{
			NamespaceName:                       &namespace,
			BucketName:                          &bname,
			ObjectName:                          &objectName,
			EnableMultipartChecksumVerification: common.Bool(true),
		},
		// ...
	}

	// I got a client error if `ObjectStorageClient` is set manually.
	_, err := uploadManager.UploadStream(ctx, req)
	// ...
}

[KartikShrikantHegde]

@urunimi assigning this issue to the Object Storage team to take a look and suggest.