Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v65.77.1 appears to be have tagged the wrong release #538

Open
iwahbe opened this issue Oct 31, 2024 · 2 comments
Open

v65.77.1 appears to be have tagged the wrong release #538

iwahbe opened this issue Oct 31, 2024 · 2 comments
Labels
SDK Issue pertains to the SDK itself and not specific to any service

Comments

@iwahbe
Copy link

iwahbe commented Oct 31, 2024

I think that https://github.com/oracle/oci-go-sdk/releases/tag/v65.77.1 was double tagged. Go serves v65.77.1 from a tag published on Oct 23, 2024 (source).

This doesn't make sense, since v65.77.1 was published on Oct 29, 2024.

The result is that a dependency that depends on features in v65.77.1 fails to compile.

You can reproduce the result yourself with this program (since containerengine.InstallAddonRequest.IsOverrideExisting was added in v65.77.1):

package main

import (
	"fmt"

	"github.com/oracle/oci-go-sdk/v65/containerengine"
)

func main() {
	request := containerengine.InstallAddonRequest{}
	var b bool
	request.IsOverrideExisting = &b
	fmt.Println("Hello, 世界")
}

I think the easiest way to fix this would be to publish v65.77.2.

@richachugh11 richachugh11 added the SDK Issue pertains to the SDK itself and not specific to any service label Nov 7, 2024
@JoshuaWR
Copy link
Member

Hi @iwahbe, thanks for pointing this out. I'm unsure of why exactly you are running into this error with this specific release, as I do see that the 65.77.1 draft release and tag seem to point to the correct commit: https://github.com/oracle/oci-go-sdk/releases/tag/v65.77.1. Either way, the next release version is v65.78.0 - could you try this release out and see if it contains the changes you need? Thank you

@iwahbe
Copy link
Author

iwahbe commented Nov 13, 2024

Hi @JoshuaWR. Thanks for getting back to me. The 65.77.1 releases point to the correct commit in GitHub, but pkg.go.dev (which go mod uses) cached the wrong commit. My best guess is that the tag was moved.

v65.78.0 at least points to the right day in pkg.go.dev, so I'll assume its the right commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDK Issue pertains to the SDK itself and not specific to any service
Projects
None yet
Development

No branches or pull requests

3 participants