Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing vault secrets that has pending deletion secrets causes spring application to crash #152

Closed
JonathanVuurstaek opened this issue Nov 7, 2024 · 3 comments · Fixed by #154
Assignees
Labels
bug Something isn't working

Comments

@JonathanVuurstaek
Copy link

Issue
I have an application setup to retrieve all secrets from a certain vault using the property-sources setup. When spring tried to read the secrets it also read secrets that are marked "pending deletion" which causes an error and crashes my spring application. If there are already solutions out there I am happy to hear.

Solution
I would expect that it should only retrie secrets that have LifeCycleState "ACTIVE". Theoratically adding the lifecycState line into the request builder should resolve this isue.

com.oracle.bmc.vault.requests.ListSecretsRequest:153

ListSecretsRequest request = ListSecretsRequest.builder()
                    .vaultId(vaultId)
                    .compartmentId(compartmentId)
                    .lifecycleState(LifecycleState.Active)
                    .page(page)
                    .build();

Properties

image

@andytael andytael added the bug Something isn't working label Nov 7, 2024
@markxnelson
Copy link
Member

Thanks very much for reporting the issue, we will take a look and get back to you

@anders-swanson
Copy link
Member

Hi @JonathanVuurstaek, this should be fixed in #154. We'll add this to the next release 👍

@JonathanVuurstaek
Copy link
Author

@anders-swanson Thank you for the quick reaction and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants