-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of binding variables and methods #46
Comments
Particularly interesting is whether the underlying resourceResolver/session is derived from the user session bound to the request or always an admin or service resource resolver/session. |
Good idea, I'll add some docs! It isn't certain on what resource resolver is used, this depends on the ScriptContext used. For example if you use the groovy console through the UI, it will be user bound because it uses the RequestScriptContext: But if you use the groovy console through AECU, it will be a service user: https://github.com/valtech/aem-easy-content-upgrade/blob/develop/core/src/main/java/de/valtech/aecu/core/service/AecuServiceImpl.java#L180 |
@royteeuwen Thanks for picking it up, but then I am wondering, what this service user is used for in Groovy Console: Line 8 in 1100331
|
Compare with the related valtech/aem-easy-content-upgrade#220 |
All methods/objects which are provided by default in the script context should have an improved documentation.
This includes e.g. methods added via any of the classes in https://github.com/orbinson/aem-groovy-console/tree/1100331993e8799f2d6c82223e9950e5d1945fed/bundle/src/main/groovy/be/orbinson/aem/groovy/console/extension/impl/scriptmetaclass or objects added via the classes in https://github.com/orbinson/aem-groovy-console/tree/1100331993e8799f2d6c82223e9950e5d1945fed/bundle/src/main/groovy/be/orbinson/aem/groovy/console/extension/impl/binding.
The documentation in http://localhost:4502/groovyconsole is not enough, as this does not expose any description on binding variables and no detailled description on parameters for methods.
The text was updated successfully, but these errors were encountered: