From 59af02d4e277b51162ad7358d32f0b68083f001d Mon Sep 17 00:00:00 2001 From: Paul Cretu Date: Thu, 12 Dec 2024 01:50:04 +0000 Subject: [PATCH 01/22] Add join button to desktop nav --- ui/src/components/Header.tsx | 36 ++++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/ui/src/components/Header.tsx b/ui/src/components/Header.tsx index 569558bb..41ac4301 100644 --- a/ui/src/components/Header.tsx +++ b/ui/src/components/Header.tsx @@ -4,6 +4,7 @@ import { Home, Menu, Notifications, + Person, } from "@mui/icons-material"; import { AppBar, @@ -230,31 +231,46 @@ function Desktop() { justifyContent: "center", textDecoration: "none", textTransform: "uppercase", - "&:hover": { color: "#ccc" }, mx: 1, }} onClick={() => analytics.nav.notificationsClicked()} > + analytics.nav.joinClicked()} + > + + From 13ce58b40f8d16b92542f390d92c3839f77586d2 Mon Sep 17 00:00:00 2001 From: Paul Cretu Date: Thu, 12 Dec 2024 03:32:16 +0000 Subject: [PATCH 02/22] Refactor unnecessary styles --- ui/src/components/Header.tsx | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/ui/src/components/Header.tsx b/ui/src/components/Header.tsx index 41ac4301..e44f3ba8 100644 --- a/ui/src/components/Header.tsx +++ b/ui/src/components/Header.tsx @@ -211,11 +211,11 @@ function Desktop() { href={page.url} target="_blank" key={page.label} + variant="text" sx={{ my: 2, mx: 1, color: "base.contrastText", - display: "block", }} > {page.label} @@ -226,11 +226,7 @@ function Desktop() { title="Get notified when there's whale activity." target="_blank" sx={{ - display: "flex", - alignItems: "center", - justifyContent: "center", - textDecoration: "none", - textTransform: "uppercase", + my: 2, mx: 1, }} onClick={() => analytics.nav.notificationsClicked()} @@ -250,22 +246,18 @@ function Desktop() { href="/join" title="Join Orcasound" sx={{ - display: "flex", - alignItems: "center", - justifyContent: "center", - textDecoration: "none", - textTransform: "uppercase", + my: 2, mx: 1, }} // TODO(@paulcretu): Add analytics event // onClick={() => analytics.nav.joinClicked()} > +