Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Allow for pagination and better filtering among reports #27

Open
bobek opened this issue Oct 17, 2017 · 4 comments
Open

Allow for pagination and better filtering among reports #27

bobek opened this issue Oct 17, 2017 · 4 comments

Comments

@bobek
Copy link
Contributor

bobek commented Oct 17, 2017

Hi, I've need to be able to define more extensive filters on reports and also noticed that you don't do pagination, which yield in missing records. I've hacked something quickly in https://github.com/Showmax/hackerone-client/tree/reports-find . It should be considered WIP, for example abstracting pagination out of this methods and actually making it more robust (similarly to your parse_response method).

But I thought that you may be interested in the work.

@oreoshake
Copy link
Owner

Thanks for the branch! I hadn't even thought about pagination, thankfully our queries always return a small result.

Just some bikesheding: I think we should augment the existing reports method rather than adding a new one.

@bobek
Copy link
Contributor Author

bobek commented Oct 23, 2017

Just some bikesheding: I think we should augment the existing reports method rather than adding a new one.

I am totally for it. I've just created a new method to separate the code at the moment, before I get some feedback from you.

@esjee
Copy link
Collaborator

esjee commented Oct 31, 2017

This is really great! Would you be up for creating a pull request? Is there anything I can do to help you?

@oreoshake
Copy link
Owner

Just adding a note here that independent of pagination implementation, we should eventually add an auto-paginate feature a la octokit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants