Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OreSat0.5 24 hour reset did not happen #38

Open
ryanpdx opened this issue Aug 18, 2024 · 1 comment
Open

OreSat0.5 24 hour reset did not happen #38

ryanpdx opened this issue Aug 18, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ryanpdx
Copy link
Member

ryanpdx commented Aug 18, 2024

Looking at the beacon from OreSat0.5, the 24 hour reset did not happen.

This could be an issue with this app or the watchdog app.

Need to test on FlatSat with a C3 with the OreSat0.5 flight image without the watchdog surrogate.

@ryanpdx ryanpdx added the bug Something isn't working label Aug 18, 2024
@ryanpdx ryanpdx self-assigned this Aug 25, 2024
@ryanpdx ryanpdx moved this from Todo to In Progress in Space Segment Aug 25, 2024
@ThirteenFish
Copy link
Contributor

This was caused by passing a list of arguments for stopping the watchdog to subprocess.run() with shell=True here. The docs say:

On POSIX with shell=True, ... if args is a sequence, the first item specifies the command string, and any additional items will be treated as additional arguments to the shell itself.

In our case then we were running just systemctl but then passing stop and oresat-c3-watchdog to /bin/sh as arguments. Fixed by deleting the shell=True line as seen in this commit and will be applied in the c3 patch 1.

I've verified that this fixes the problem as part of testing the patch by setting 0x4001 reset_timeout to 300s and watching flatsat successfully reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Implementing
Development

No branches or pull requests

2 participants