Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply SDLS to USLP Primary Header #42

Open
ThirteenFish opened this issue Sep 6, 2024 · 0 comments
Open

Apply SDLS to USLP Primary Header #42

ThirteenFish opened this issue Sep 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ThirteenFish
Copy link
Contributor

SDLS 3.2.2.5 specifies that:

The USLP ApplySecurity Payload shall consist of the portion of the USLP Transfer Frame from the first octet of the Transfer Frame Primary Header to the last octet of the Transfer Frame Data Field.

See also SDLS 5.4 for a concise diagram and 4.2.3.4 for method of operation.

We only apply it to the Data Field, but not the Primary Header. There's some provisions (SDLS 4.2.2.6.2) for masking off portions of the payload for authentication but we really want to include all of it.

Also SDLS authentication has a mandatory security header that we don't implement (SDLS 4.1.1, 4.2.3.4). It'd be nice for correctness to have it, but that's a bigger EDL protocol change than the above.

@ThirteenFish ThirteenFish added the bug Something isn't working label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant