Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme system #1045

Open
Su-Yong opened this issue Aug 3, 2024 · 0 comments
Open

New theme system #1045

Su-Yong opened this issue Aug 3, 2024 · 0 comments
Assignees
Labels
Type: Enhancement New feature or request
Milestone

Comments

@Su-Yong
Copy link
Member

Su-Yong commented Aug 3, 2024

Structure

{
  "variables": {
    "@override": true,
    "[variable_name]": {
      "type": "number",
      "default": 10
      "expose": {
        "label": {
          "en": "Setting Label"
        },
		"description": {
		  "en": "description"
		}
      }
    }
  },
  "style": {
    "wrapper": {
      "@override": false,
      "style": "asdf"
    }
  },
  "render": {
    "type": "wrapper",
    "children": [
      {
        "type": "Lyric",
      },
      // ...
    ]
  }
}
  • @override: override field

Render

interface BaseRenderElement<Type extends string> {
  type: Type;
  children?: RenderElement[];
}

type WrapperRenderElement = BaseRenderElement<'wrapper'>;
type LyricGroupRenderElement = // ...
type LyricRenderElement = // ...

type RenderElement = WrapperRenderElement | LyricGroupRenderElement | // ...;
@Su-Yong Su-Yong added the Type: Enhancement New feature or request label Aug 3, 2024
@Su-Yong Su-Yong added this to the 1.0.0 milestone Aug 3, 2024
@Su-Yong Su-Yong self-assigned this Aug 3, 2024
@Su-Yong Su-Yong changed the title 새로운 테마 시스템 New theme system Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant