[BioSequences.jl] Search #4
CiaranOMara
started this conversation in
General
Replies: 1 comment 1 reply
-
@CiaranOMara Apologies for never responding to this... better (2 years) late than never? 😬 I have a vague recollection that some work has been done on this in the meantime - is there a more updated discussion? |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I think there are some things regarding BioSequence's search mehods that are worth discussing.
Since I'm short on time, what follows are notes/bullet points. But, hopefully, they are sufficient to start a consensus, and then maybe some courses of action.
I believe there is a question as to what type of search result is most useful. Is it useful to return a range, is it better to return nothing, or have both by keeping lower-level functions that return ranges available? On a related note, does chaining search queries make sense?
Subtype search queries from
abstract type SearchQuery end
and consolidate an interface for:I like
findnext(predicate/query::SearchQuery, seq::BioSequence, start::Integer, stop::Integer)
.New features:
findall
search variant, which could set and collect from an iterator.Thoughts @TransGirlCodes @jakobnissen @kescobo?
Beta Was this translation helpful? Give feedback.
All reactions