Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect TypeScript def for create record #434

Open
mebibou opened this issue May 20, 2020 · 2 comments
Open

Incorrect TypeScript def for create record #434

mebibou opened this issue May 20, 2020 · 2 comments

Comments

@mebibou
Copy link

mebibou commented May 20, 2020

When trying to create a record like this:

const Player = await db.class.get('Player');
const record = await Player.create({ name: 'new player' });

typescript will fail with an error because the expected param for create is a ORecord although it should just be an Object

@saeedtabrizi
Copy link
Contributor

Hi @mebibou
Thanks to inform , i will try to patch it asap.

@saeedtabrizi
Copy link
Contributor

saeedtabrizi commented Sep 18, 2020

I just push a new definition that embedded to orientjs package and resolve some typings problems.
implemented issues in #438 , #439
@mebibou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants