From 50b21ed149d9619f312358dce201ec392352431f Mon Sep 17 00:00:00 2001 From: Henning Perl Date: Thu, 12 Sep 2024 09:25:54 +0200 Subject: [PATCH] code review --- persistence/sql/batch/create_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/persistence/sql/batch/create_test.go b/persistence/sql/batch/create_test.go index 31c736cdc847..60ef6af4734a 100644 --- a/persistence/sql/batch/create_test.go +++ b/persistence/sql/batch/create_test.go @@ -121,10 +121,10 @@ func Test_buildInsertQueryValues(t *testing.T) { values, err := buildInsertQueryValues(dbal.DriverCockroachDB, mapper, []string{"created_at", "updated_at", "id", "string", "int", "null_time_ptr", "traits"}, []*testModel{model}, nowFunc) require.NoError(t, err) - assert.NotNil(t, model.CreatedAt) + assert.NotZero(t, model.CreatedAt) assert.Equal(t, model.CreatedAt, values[0]) - assert.NotNil(t, model.UpdatedAt) + assert.NotZero(t, model.UpdatedAt) assert.Equal(t, model.UpdatedAt, values[1]) assert.NotZero(t, model.ID) @@ -140,10 +140,10 @@ func Test_buildInsertQueryValues(t *testing.T) { values, err := buildInsertQueryValues("other", mapper, []string{"created_at", "updated_at", "id", "string", "int", "null_time_ptr", "traits"}, []*testModel{model}, nowFunc) require.NoError(t, err) - assert.NotNil(t, model.CreatedAt) + assert.NotZero(t, model.CreatedAt) assert.Equal(t, model.CreatedAt, values[0]) - assert.NotNil(t, model.UpdatedAt) + assert.NotZero(t, model.UpdatedAt) assert.Equal(t, model.UpdatedAt, values[1]) assert.NotZero(t, model.ID)