Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make discovery work in monorepo (yarn) #15

Open
andersevenrud opened this issue Aug 4, 2022 · 3 comments
Open

Make discovery work in monorepo (yarn) #15

andersevenrud opened this issue Aug 4, 2022 · 3 comments

Comments

@andersevenrud
Copy link
Member

No description provided.

@ajmeese7
Copy link
Member

ajmeese7 commented Aug 9, 2022

I can't speak to yarn but the discovery works fine in my monorepo with Rush, what issues are you encountering with the yarn workspace?

@andersevenrud
Copy link
Member Author

andersevenrud commented Aug 9, 2022

Package discovery don't go down the tree, it's always relative to the OS.js installation path.

This doesn't really work well if you have all dependencies a few levels down.

I.e.:

packages/osjs-filemanager-application/
packages/osjs-client/
packages/osjs-server/
distros/os.js/
node_modules/ <-- uh, uh

@andersevenrud
Copy link
Member Author

andersevenrud commented Aug 9, 2022

NB: This is using the "workspaces" feature (which now also is in latest npm, albeit slightly different).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants